From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57148) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLcIV-0007qe-58 for qemu-devel@nongnu.org; Thu, 06 Mar 2014 12:41:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLcIM-0005oi-Ne for qemu-devel@nongnu.org; Thu, 06 Mar 2014 12:41:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:17182) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLcIM-0005oD-FN for qemu-devel@nongnu.org; Thu, 06 Mar 2014 12:41:22 -0500 Date: Thu, 6 Mar 2014 19:41:10 +0200 From: "Michael S. Tsirkin" Message-ID: <20140306174110.GB7536@redhat.com> References: <1393979937-9082-1-git-send-email-minyard@acm.org> <1393979937-9082-3-git-send-email-minyard@acm.org> <53181A10.6070203@huawei.com> <5318ADC8.1060708@mvista.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5318ADC8.1060708@mvista.com> Subject: Re: [Qemu-devel] [PATCH 2/7] qemu-char: Allow a chardev to reconnect if disconnected List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Corey Minyard Cc: bcketchum@gmail.com, Weidong Huang , qemu-devel@nongnu.org, minyard@acm.org, afaerber@suse.de On Thu, Mar 06, 2014 at 11:18:00AM -0600, Corey Minyard wrote: > On 03/06/2014 12:47 AM, Weidong Huang wrote: > > escape sequences. > > > > +@option{reconnect} specifies that if the client socket does not connect at > > +startup, or if the client socket is closed for some reason (like the other > > +end exited), wait the given number of seconds and attempt to reconnect. > > + > > TCP and unix socket options are given below: > > > > @table @option > > The client will reconnect for ever when the server is dead. Is it better that try to reconnect several times? > > Or add a option which specifies times of reconnect? > > > I'm not really sure about this. For a remote IPMI BMC, you would want > it to reconnect for forever, there's no point it having it stop trying > after a while, since you want it to come back even if the BMC is down > for a day. I would think the same if you wanted a remote console or > something of that nature. > > What's the use case where you would want it to stop trying? I can't > think of any. > > Thanks, > > -corey Depends on what happens after it fails. Imagine whoever was using the socket is gone. It might be useful to stop VM or exit after a while rather than just hang about. -- MST