From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58871)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1WLpOA-0008Mh-G4
	for qemu-devel@nongnu.org; Fri, 07 Mar 2014 02:40:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1WLpO2-00037m-Hj
	for qemu-devel@nongnu.org; Fri, 07 Mar 2014 02:40:14 -0500
Received: from mx1.redhat.com ([209.132.183.28]:2267)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1WLpO2-0002uC-AR
	for qemu-devel@nongnu.org; Fri, 07 Mar 2014 02:40:06 -0500
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s277e1Pn030190
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 7 Mar 2014 02:40:02 -0500
Date: Fri, 7 Mar 2014 15:40:15 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20140307074015.GC2514@T430.nay.redhat.com>
References: <1394101677-21745-1-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1394101677-21745-1-git-send-email-pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] virtio-scsi: actually honor sense_size
 from configuration space
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

On Thu, 03/06 11:27, Paolo Bonzini wrote:
> We were always truncating the sense size to 96 bytes.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  hw/scsi/virtio-scsi.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c
> index 6610b3a..b0d7517 100644
> --- a/hw/scsi/virtio-scsi.c
> +++ b/hw/scsi/virtio-scsi.c
> @@ -304,6 +304,8 @@ static void virtio_scsi_command_complete(SCSIRequest *r, uint32_t status,
>                                           size_t resid)
>  {
>      VirtIOSCSIReq *req = r->hba_private;
> +    VirtIOSCSI *s = req->dev;
> +    VirtIOSCSICommon *vs = VIRTIO_SCSI_COMMON(s);
>      uint32_t sense_len;
>  
>      if (r->io_canceled) {
> @@ -317,7 +319,7 @@ static void virtio_scsi_command_complete(SCSIRequest *r, uint32_t status,
>      } else {
>          req->resp.cmd->resid = 0;
>          sense_len = scsi_req_get_sense(r, req->resp.cmd->sense,
> -                                       VIRTIO_SCSI_SENSE_SIZE);
> +                                       vs->sense_size);
>          req->resp.cmd->sense_len = tswap32(sense_len);
>      }
>      virtio_scsi_complete_req(req);


Do we need to increase VIRTIO_SCSI_SENSE_SIZE as well?

    $ git grep -n VIRTIO_SCSI_SENSE_SIZE
    hw/scsi/virtio-scsi.c:463:    vs->sense_size = VIRTIO_SCSI_SENSE_SIZE;
    hw/scsi/virtio-scsi.c:609:    s->sense_size = VIRTIO_SCSI_SENSE_SIZE;
    include/hw/virtio/virtio-scsi.h:40:#define VIRTIO_SCSI_SENSE_SIZE  96

Fam