From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44366) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WML1o-000222-CN for qemu-devel@nongnu.org; Sat, 08 Mar 2014 12:27:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WML1j-00015L-H0 for qemu-devel@nongnu.org; Sat, 08 Mar 2014 12:27:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:14608) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WML1j-00015E-90 for qemu-devel@nongnu.org; Sat, 08 Mar 2014 12:27:11 -0500 Date: Sat, 8 Mar 2014 12:27:06 -0500 From: Luiz Capitulino Message-ID: <20140308122706.58858d92@redhat.com> In-Reply-To: References: <20140308110933.28374e9a@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH] tests: test-qmp-commands: Fix double free List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers , Markus Armbruster The ret variable is freed twice, but on the second time we actually want to free ret3 instead. Don't know why this didn't explode. Reported-by: Peter Maydell Tested-by: Peter Maydell Signed-off-by: Luiz Capitulino --- tests/test-qmp-commands.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test-qmp-commands.c b/tests/test-qmp-commands.c index 8e62c2d..554e222 100644 --- a/tests/test-qmp-commands.c +++ b/tests/test-qmp-commands.c @@ -141,7 +141,7 @@ static void test_dispatch_cmd_io(void) ret3 = qobject_to_qint(test_qmp_dispatch(req)); assert(qint_get_int(ret3) == 66); - QDECREF(ret); + QDECREF(ret3); QDECREF(req); } -- 1.8.1.4