From: Leandro Dorileo <l@dorileo.org>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Kevin Wolf <kwolf@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Fam Zheng <famz@redhat.com>, Stefan Weil <sw@weilnetz.de>,
Michael Tokarev <mjt@tls.msk.ru>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Laszlo Ersek <lersek@redhat.com>, Peter Lieven <pl@kamp.de>
Subject: Re: [Qemu-devel] [PATCH RFC 0/2] qemu-arg: general purpose argument parser
Date: Sun, 9 Mar 2014 21:47:39 +0000 [thread overview]
Message-ID: <20140309214739.GA13590@dorilex> (raw)
In-Reply-To: <531C9791.10207@suse.de>
Hi Andreas,
On Sun, Mar 09, 2014 at 05:32:17PM +0100, Andreas Färber wrote:
> Am 08.03.2014 19:47, schrieb Leandro Dorileo:
> > The following patchset introduces a general purpose argument parser and migrates
> > qemu-img to make use of it. qemu-img is just the first user of it, if we see a
> > good feedback here I move forward and migrate all the other possible users.
>
> Why? :) You forgot to describe what's wrong with the current
> infrastructure, how your approach is different and what the benefit is.
>
Indead, I failed miserably on that (describing the problem intended to be solved).
The general sense is to unify the argument parsing strategies with some benefits
like help generation. If you see, every qemu binary has its own strategy - where
some (most?) use getopt and the QEMU main binary uses QemuOpt, they lack a runtine
help message generation, the sync between the help message and expected/implemented
arguments are done manually.
But I'm not sure if we really want/need it, that's the why I sent an early RFC. For
me it was just few weekend hours putting all together. :)
I see a good benefit on that - having a simple, clean, consistent and common API
throughout the source code. But again, do we want it? is it worth it?
Regards...
--
Leandro Dorileo
next prev parent reply other threads:[~2014-03-09 21:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-08 18:47 [Qemu-devel] [PATCH RFC 0/2] qemu-arg: general purpose argument parser Leandro Dorileo
2014-03-08 18:47 ` [Qemu-devel] [PATCH RFC 1/2] qemu-arg: introduce a " Leandro Dorileo
2014-03-08 18:47 ` [Qemu-devel] [PATCH RFC 2/2] qemu-img: migrate to use qemu-arg Leandro Dorileo
2014-03-09 7:30 ` Paolo Bonzini
2014-03-09 12:37 ` Leandro Dorileo
2014-03-09 13:03 ` Peter Maydell
2014-03-09 13:35 ` Leandro Dorileo
2014-03-08 18:55 ` [Qemu-devel] [PATCH RFC 0/2] qemu-arg: general purpose argument parser Peter Maydell
2014-03-08 20:28 ` Leandro Dorileo
2014-03-09 16:32 ` Andreas Färber
2014-03-09 21:47 ` Leandro Dorileo [this message]
2014-03-11 11:06 ` Kevin Wolf
2014-03-11 14:09 ` Leandro Dorileo
2014-03-11 15:22 ` Eric Blake
2014-03-16 21:23 ` Leandro Dorileo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140309214739.GA13590@dorilex \
--to=l@dorileo.org \
--cc=afaerber@suse.de \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=lersek@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).