From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56209)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <janne@jannau.net>) id 1WN2Dz-000805-Ox
	for qemu-devel@nongnu.org; Mon, 10 Mar 2014 11:34:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <janne@jannau.net>) id 1WN2Dp-0004gt-UB
	for qemu-devel@nongnu.org; Mon, 10 Mar 2014 11:34:43 -0400
Received: from soltyk.jannau.net ([185.27.253.110]:44265)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <janne@jannau.net>) id 1WN2Dp-0004gE-P2
	for qemu-devel@nongnu.org; Mon, 10 Mar 2014 11:34:33 -0400
Date: Mon, 10 Mar 2014 16:34:31 +0100
From: Janne Grunau <j@jannau.net>
Message-ID: <20140310153431.GW20660@jannau.net>
References: <1394377867-7115-1-git-send-email-peter.maydell@linaro.org>
	<1394377867-7115-7-git-send-email-peter.maydell@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <1394377867-7115-7-git-send-email-peter.maydell@linaro.org>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 06/16] target-arm: A64: Saturating and
 narrowing shift ops
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, patches@linaro.org, Michael Matz <matz@suse.de>, Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org, Laurent Desnogues <laurent.desnogues@gmail.com>, Dirk Mueller <dmueller@suse.de>, Will Newton <will.newton@linaro.org>, Alex =?iso-8859-1?Q?Benn=E9e?= <alex.bennee@linaro.org>, kvmarm@lists.cs.columbia.edu, Christoffer Dall <christoffer.dall@linaro.org>, Richard Henderson <rth@twiddle.net>

On 2014-03-09 15:10:57 +0000, Peter Maydell wrote:
> From: Alex Benn=E9e <alex.bennee@linaro.org>
>=20
> This implements a the remaining [US][R]SHR[R][2] opcodes which are

there is an extra 'a' and the instructions are [US][Q][R]SHR[U][N][2].
The last '[R]' is at least clearly wrong.

The commit itself looks correct and is tested with libav's test suite.

Janne