From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, qemu-ppc@nongnu.org,
qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH 12/12] hw/pci-host/apb.c: Avoid shifting left into sign bit
Date: Mon, 10 Mar 2014 23:59:10 +0200 [thread overview]
Message-ID: <20140310215910.GE7104@redhat.com> (raw)
In-Reply-To: <1394478649-9453-13-git-send-email-peter.maydell@linaro.org>
On Mon, Mar 10, 2014 at 07:10:48PM +0000, Peter Maydell wrote:
> Add U suffix to avoid undefined behaviour.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
While not required for correctness, it would be cleaner
to change all constants around this line to 1U <<, for consistency.
> ---
> hw/pci-host/apb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/pci-host/apb.c b/hw/pci-host/apb.c
> index 1b399dd..a6869b8 100644
> --- a/hw/pci-host/apb.c
> +++ b/hw/pci-host/apb.c
> @@ -58,7 +58,7 @@ do { printf("APB: " fmt , ## __VA_ARGS__); } while (0)
> #define PBM_PCI_IMR_MASK 0x7fffffff
> #define PBM_PCI_IMR_ENABLED 0x80000000
>
> -#define POR (1 << 31)
> +#define POR (1U << 31)
> #define SOFT_POR (1 << 30)
> #define SOFT_XIR (1 << 29)
> #define BTN_POR (1 << 28)
> --
> 1.9.0
>
next prev parent reply other threads:[~2014-03-10 21:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 19:10 [Qemu-devel] [PATCH 00/12] Avoid shifting left into sign bit Peter Maydell
2014-03-10 19:10 ` [Qemu-devel] [PATCH 01/12] target-i386: " Peter Maydell
2014-03-10 21:57 ` Michael S. Tsirkin
2014-03-10 19:10 ` [Qemu-devel] [PATCH 02/12] hw/intc/apic.c: Use uint32_t for mask word in foreach_apic Peter Maydell
2014-03-10 19:39 ` Stefan Weil
2014-03-10 21:56 ` Michael S. Tsirkin
2014-03-10 19:10 ` [Qemu-devel] [PATCH 03/12] hw/pci/pci_host.c: Avoid shifting left into sign bit Peter Maydell
2014-03-10 20:03 ` Stefan Weil
2014-03-10 21:46 ` Michael S. Tsirkin
2014-03-10 21:58 ` Michael S. Tsirkin
2014-03-10 19:10 ` [Qemu-devel] [PATCH 04/12] hw/i386/acpi_build.c: " Peter Maydell
2014-03-10 21:56 ` Michael S. Tsirkin
2014-03-10 19:10 ` [Qemu-devel] [PATCH 05/12] target-mips: " Peter Maydell
2014-03-10 19:10 ` [Qemu-devel] [PATCH 06/12] hw/usb/hcd-ohci.c: " Peter Maydell
2014-03-10 19:10 ` [Qemu-devel] [PATCH 07/12] hw/intc/openpic: " Peter Maydell
2014-03-10 19:10 ` [Qemu-devel] [PATCH 08/12] hw/ppc: " Peter Maydell
2014-03-10 19:10 ` [Qemu-devel] [PATCH 09/12] tests/libqos/pci-pc: " Peter Maydell
2014-03-10 19:10 ` [Qemu-devel] [PATCH 10/12] hw/intc/slavio_intctl: " Peter Maydell
2014-03-10 19:10 ` [Qemu-devel] [PATCH 11/12] hw/intc/xilinx_intc: " Peter Maydell
2014-03-10 19:10 ` [Qemu-devel] [PATCH 12/12] hw/pci-host/apb.c: " Peter Maydell
2014-03-10 21:59 ` Michael S. Tsirkin [this message]
2014-03-14 16:45 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-03-10 22:00 ` [Qemu-devel] [PATCH 00/12] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140310215910.GE7104@redhat.com \
--to=mst@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).