From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34913)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1WNMUt-0007am-95
	for qemu-devel@nongnu.org; Tue, 11 Mar 2014 09:13:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1WNMUo-0004vE-1G
	for qemu-devel@nongnu.org; Tue, 11 Mar 2014 09:13:31 -0400
Received: from mx1.redhat.com ([209.132.183.28]:32537)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1WNMUn-0004uC-Q7
	for qemu-devel@nongnu.org; Tue, 11 Mar 2014 09:13:25 -0400
Date: Tue, 11 Mar 2014 09:13:20 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20140311091320.3801fcf1@redhat.com>
In-Reply-To: <87txb5w0rr.fsf@blackfin.pond.sub.org>
References: <1394463290-24929-1-git-send-email-armbru@redhat.com>
	<20140310121642.3a28896e@redhat.com>
	<87txb5w0rr.fsf@blackfin.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] tests/qapi-schema: Fix enum misuse in flat
 union type tests
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org

On Tue, 11 Mar 2014 10:19:20 +0100
Markus Armbruster <armbru@redhat.com> wrote:

> Luiz Capitulino <lcapitulino@redhat.com> writes:
> 
> > On Mon, 10 Mar 2014 15:54:50 +0100
> > Markus Armbruster <armbru@redhat.com> wrote:
> >
> >> Screwed up in commit 2fc0043.  Currently harmless, because the enum
> >> values happen to be identical.
> >
> > I'm afraid this conflicts with Wenchao's series:
> >
> >  [PATCH V9 00/10] qapi script: support enum as discriminator and
> > better enum name
> >
> > Which is already merged in my qmp queue:
> >
> >  git://repo.or.cz/qemu/qmp-unstable.git queue/qmp
> 
> Conflicts because it fixes the bug silently.
> 
> If we want a record of the bug fix, we can either rebase his series on
> top of mine, or amend one of his commit messages.  I'm not sure it's
> worth the bother, though.  I can give it a try if you think it's
> worthwhile.

I don't think it is.