From: Stefan Hajnoczi <stefanha@gmail.com>
To: Marcel Apfelbaum <marcel.a@redhat.com>
Cc: kwolf@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org,
armbru@redhat.com, aliguori@amazon.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH V2 2/2] tests: Tweak the Makefile to produce per-test output.
Date: Tue, 11 Mar 2014 13:45:12 +0100 [thread overview]
Message-ID: <20140311124512.GB7761@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1394532550-21857-3-git-send-email-marcel.a@redhat.com>
On Tue, Mar 11, 2014 at 12:09:10PM +0200, Marcel Apfelbaum wrote:
> From: Stefan Hajnoczi <stefanha@redhat.com>
>
> The effect is that the output will grow, but we will know
> which qtest failed. This helps when an asert is made on
> other code and not in the test itself.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com>
> ---
> tests/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/Makefile b/tests/Makefile
> index b17d41e..a8405c8 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -273,7 +273,7 @@ check-help:
> @echo "changed with variable GTESTER_OPTIONS."
>
> SPEED = quick
> -GTESTER_OPTIONS = -k $(if $(V),--verbose,-q)
> +GTESTER_OPTIONS = -k #$(if $(V),--verbose,-q)
> GCOV_OPTIONS = -n $(if $(V),-f,)
>
> # gtester tests, possibly with verbose output
I didn't propose this as a QEMU patch so I didn't add my Signed-off-by:.
I just posted a diff to show you that gtester without -q prints the test
binary names.
Please drop this patch and I'll send a final patch after I've checked
the output is still clean and doesn't duplicate information.
next prev parent reply other threads:[~2014-03-11 12:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 10:09 [Qemu-devel] [PATCH V2 0/2] tests: Fix possible deadlock in qtest initialization Marcel Apfelbaum
2014-03-11 10:09 ` [Qemu-devel] [PATCH V2 1/2] tests/libqtest: " Marcel Apfelbaum
2014-03-11 12:40 ` Stefan Hajnoczi
2014-03-11 12:51 ` Marcel Apfelbaum
2014-03-11 13:04 ` Marcel Apfelbaum
2014-03-11 18:50 ` Stefan Hajnoczi
2014-03-11 10:09 ` [Qemu-devel] [PATCH V2 2/2] tests: Tweak the Makefile to produce per-test output Marcel Apfelbaum
2014-03-11 12:07 ` Eric Blake
2014-03-11 12:27 ` Marcel Apfelbaum
2014-03-11 12:45 ` Stefan Hajnoczi [this message]
2014-03-11 12:52 ` Marcel Apfelbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140311124512.GB7761@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=afaerber@suse.de \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcel.a@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).