From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55099)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WNM3g-00062N-Ju
	for qemu-devel@nongnu.org; Tue, 11 Mar 2014 08:45:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WNM3Y-0003dB-2e
	for qemu-devel@nongnu.org; Tue, 11 Mar 2014 08:45:24 -0400
Received: from mail-ee0-x22e.google.com ([2a00:1450:4013:c00::22e]:60515)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WNM3X-0003cx-RV
	for qemu-devel@nongnu.org; Tue, 11 Mar 2014 08:45:15 -0400
Received: by mail-ee0-f46.google.com with SMTP id t10so3689163eei.19
	for <qemu-devel@nongnu.org>; Tue, 11 Mar 2014 05:45:15 -0700 (PDT)
Date: Tue, 11 Mar 2014 13:45:12 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20140311124512.GB7761@stefanha-thinkpad.redhat.com>
References: <1394532550-21857-1-git-send-email-marcel.a@redhat.com>
	<1394532550-21857-3-git-send-email-marcel.a@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1394532550-21857-3-git-send-email-marcel.a@redhat.com>
Subject: Re: [Qemu-devel] [PATCH V2 2/2] tests: Tweak the Makefile to
 produce per-test output.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcel Apfelbaum <marcel.a@redhat.com>
Cc: kwolf@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, aliguori@amazon.com, afaerber@suse.de

On Tue, Mar 11, 2014 at 12:09:10PM +0200, Marcel Apfelbaum wrote:
> From: Stefan Hajnoczi <stefanha@redhat.com>
> 
> The effect is that the output will grow, but we will know
> which qtest failed. This helps when an asert is made on
> other code and not in the test itself.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com>
> ---
>  tests/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/Makefile b/tests/Makefile
> index b17d41e..a8405c8 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -273,7 +273,7 @@ check-help:
>  	@echo "changed with variable GTESTER_OPTIONS."
>  
>  SPEED = quick
> -GTESTER_OPTIONS = -k $(if $(V),--verbose,-q)
> +GTESTER_OPTIONS = -k #$(if $(V),--verbose,-q)
>  GCOV_OPTIONS = -n $(if $(V),-f,)
>  
>  # gtester tests, possibly with verbose output

I didn't propose this as a QEMU patch so I didn't add my Signed-off-by:.
I just posted a diff to show you that gtester without -q prints the test
binary names.

Please drop this patch and I'll send a final patch after I've checked
the output is still clean and doesn't duplicate information.