From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48084) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNNKO-0006iX-Lg for qemu-devel@nongnu.org; Tue, 11 Mar 2014 10:06:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNNKJ-0005ze-2Q for qemu-devel@nongnu.org; Tue, 11 Mar 2014 10:06:44 -0400 Received: from mail-ee0-x233.google.com ([2a00:1450:4013:c00::233]:62524) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNNKI-0005zX-RC for qemu-devel@nongnu.org; Tue, 11 Mar 2014 10:06:38 -0400 Received: by mail-ee0-f51.google.com with SMTP id c13so3736641eek.24 for ; Tue, 11 Mar 2014 07:06:38 -0700 (PDT) Date: Tue, 11 Mar 2014 15:06:34 +0100 From: Stefan Hajnoczi Message-ID: <20140311140634.GF7761@stefanha-thinkpad.redhat.com> References: <1394436721-21812-1-git-send-email-cyliu@suse.com> <1394436721-21812-26-git-send-email-cyliu@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1394436721-21812-26-git-send-email-cyliu@suse.com> Subject: Re: [Qemu-devel] [PATCH v22 25/25] cleanup QEMUOptionParameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chunyan Liu Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On Mon, Mar 10, 2014 at 03:32:01PM +0800, Chunyan Liu wrote: > Now all places using QEMUOptionParameter could use QemuOpts too, remove > QEMUOptionParameter related code. > > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > block.c | 69 ++------ > block/cow.c | 4 +- > block/gluster.c | 8 +- > block/qcow.c | 4 +- > block/qcow2.c | 6 +- > block/qed.c | 4 +- > block/raw-posix.c | 10 +- > block/raw-win32.c | 2 +- > block/raw_bsd.c | 4 +- > block/rbd.c | 2 +- > block/sheepdog.c | 6 +- > block/ssh.c | 2 +- > block/vdi.c | 2 +- > block/vhdx.c | 4 +- > block/vmdk.c | 6 +- > block/vpc.c | 2 +- > block/vvfat.c | 2 +- > include/block/block.h | 8 +- > include/block/block_int.h | 13 +- > include/qemu/option.h | 46 ------ > qemu-img.c | 63 +------- > util/qemu-option.c | 401 ---------------------------------------------- > 22 files changed, 62 insertions(+), 606 deletions(-) Please change the commit message to "qemu-option: remove QEMUOptionParameter". Commit messages should have a prefix that indicates which part of the codebase is affected. And "remove" is more specific than "cleanup". Reviewed-by: Stefan Hajnoczi