From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59151)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WNNup-0005Si-Oj
	for qemu-devel@nongnu.org; Tue, 11 Mar 2014 10:44:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WNNuh-00037l-A1
	for qemu-devel@nongnu.org; Tue, 11 Mar 2014 10:44:23 -0400
Received: from mail-ea0-x22b.google.com ([2a00:1450:4013:c01::22b]:49644)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WNNuh-00037f-2Q
	for qemu-devel@nongnu.org; Tue, 11 Mar 2014 10:44:15 -0400
Received: by mail-ea0-f171.google.com with SMTP id n15so4344798ead.2
	for <qemu-devel@nongnu.org>; Tue, 11 Mar 2014 07:44:14 -0700 (PDT)
Date: Tue, 11 Mar 2014 15:44:11 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20140311144411.GP7761@stefanha-thinkpad.redhat.com>
References: <1394436721-21812-1-git-send-email-cyliu@suse.com>
	<1394436721-21812-17-git-send-email-cyliu@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1394436721-21812-17-git-send-email-cyliu@suse.com>
Subject: Re: [Qemu-devel] [PATCH v22 16/25] raw_bsd.c: replace
 QEMUOptionParameter with QemuOpts
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Chunyan Liu <cyliu@suse.com>
Cc: kwolf@redhat.com, Dong Xu Wang <wdongxu@linux.vnet.ibm.com>, qemu-devel@nongnu.org, stefanha@redhat.com

On Mon, Mar 10, 2014 at 03:31:52PM +0800, Chunyan Liu wrote:
> Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
> Signed-off-by: Chunyan Liu <cyliu@suse.com>
> ---
>  block/raw_bsd.c | 27 +++++++++++++++------------
>  1 file changed, 15 insertions(+), 12 deletions(-)
> 
> diff --git a/block/raw_bsd.c b/block/raw_bsd.c
> index 9ae5fc2..ee797fd 100644
> --- a/block/raw_bsd.c
> +++ b/block/raw_bsd.c
> @@ -29,13 +29,17 @@
>  #include "block/block_int.h"
>  #include "qemu/option.h"
>  
> -static QEMUOptionParameter raw_create_options[] = {
> -    {
> -        .name = BLOCK_OPT_SIZE,
> -        .type = OPT_SIZE,
> -        .help = "Virtual disk size"
> -    },
> -    { 0 }
> +static QemuOptsList raw_create_opts = {
> +    .name = "raw-create-opts",
> +    .head = QTAILQ_HEAD_INITIALIZER(raw_create_opts.head),
> +    .desc = {
> +        {
> +            .name = BLOCK_OPT_SIZE,
> +            .type = QEMU_OPT_SIZE,
> +            .help = "Virtual disk size"
> +        },
> +        { /* end of list */ }
> +    }
>  };

Hmm...I'm not sure how this works.  The option isn't consumed so maybe
we don't need to declare it at all.  However, it's not your problem
because it was like this before already.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>