From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49210)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1WNP2Q-0000mk-Q7
	for qemu-devel@nongnu.org; Tue, 11 Mar 2014 11:56:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1WNP2L-0002rs-Rz
	for qemu-devel@nongnu.org; Tue, 11 Mar 2014 11:56:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58942)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1WNP2L-0002qW-L6
	for qemu-devel@nongnu.org; Tue, 11 Mar 2014 11:56:13 -0400
Date: Tue, 11 Mar 2014 15:55:02 +0000
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Message-ID: <20140311155502.GF2450@work-vm>
References: <1394392713-31471-1-git-send-email-mst@redhat.com>
	<1394392713-31471-9-git-send-email-mst@redhat.com>
	<531F2C52.50401@siemens.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <531F2C52.50401@siemens.com>
Subject: Re: [Qemu-devel] [PULL v3 08/14] Add a 'name' parameter to
 qemu_thread_create
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Stefan Hajnoczi <stefanha@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>, Anthony Liguori <aliguori@amazon.com>, Laszlo Ersek <lersek@redhat.com>

* Jan Kiszka (jan.kiszka@siemens.com) wrote:
> On 2014-03-09 20:20, Michael S. Tsirkin wrote:
> > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> > 
> > If enabled, set the thread name at creation (on GNU systems with
> >   pthread_set_np)
> > Fix up all the callers with a thread name
> 
> Seems like not all older Linux systems come with support for
> pthread_setname_np. Just ran into a linker bug on a box with glib 2.11.
> Can we discover the availability, if nothing helps during configure?

Gah - sorry about that; so either we can:

  1) Put a compile/link test in configure
  2) I could wrap it in   #if __GLIBC_PREREQ(2,12)
     
any preference?

> Thanks,
> Jan

Thanks for spotting it.

Dave
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK