From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33508) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNPfy-0001uN-SD for qemu-devel@nongnu.org; Tue, 11 Mar 2014 12:37:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNPfu-0002Y2-4X for qemu-devel@nongnu.org; Tue, 11 Mar 2014 12:37:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47512) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNPft-0002Xr-ST for qemu-devel@nongnu.org; Tue, 11 Mar 2014 12:37:06 -0400 Date: Tue, 11 Mar 2014 16:36:57 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20140311163657.GH2450@work-vm> References: <1394392713-31471-1-git-send-email-mst@redhat.com> <1394392713-31471-9-git-send-email-mst@redhat.com> <531F2C52.50401@siemens.com> <531F3083.9090304@siemens.com> <20140311161301.GG2450@work-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] qemu-thread-posix: Fix build against older glibc version List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Kevin Wolf , Stefan Hajnoczi , "Michael S. Tsirkin" , Jan Kiszka , QEMU Developers , Gerd Hoffmann , Anthony Liguori , Laszlo Ersek * Peter Maydell (peter.maydell@linaro.org) wrote: > On 11 March 2014 16:13, Dr. David Alan Gilbert wrote: > > * Peter Maydell (peter.maydell@linaro.org) wrote: > >> Can we have a configure test for the function instead, please? > >> We don't generally do tests for specific glibc versions > >> (among other things, glibc is not the only C library we > >> might be compiled against -- consider MacOSX, the BSDs, > >> and occasionally somebody tries to compile against one > >> of the embedded libcs). > > > > Except pthread_setname_np is not portable and was previously > > ifdef'd _GNU_SOURCE anyway > > I still think it's a generally worse way to do checks. > We currently have only one check against __GLIBC_MINOR__ > in the tree (and that's in extremely Linux-specific > code). > > > the parameters on other OSs > > maybe different (freebsd has got a 3rd parameter for no > > apparent reason). > > This rather suggests we should abstract the "set thread > name" functionality out into its own function so we > can easily provide other implementations for those > other OSes later. OK, well there is already a void os_set_proc_name(const char *s) in os-posix.c but it has ~2 problems: 1) If the OS doesn't support doing it that way it exit(1)'s 2) it uses prctl to set it on the current thread, where pthread_setname_np has the advantage that it sets it on something you have a pthread* for. 3) There isn't a matching entry in os-win32.c is the best thing to add another function to os-posix and os-win then? Dave -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK