[Qemu-devel] [PATCH] qcow2: Keep option in qcow2_invalidate_cache()

[Qemu-devel] [PATCH] qcow2: Keep option in qcow2_invalidate_cache()

[Kevin Wolf]

Instead of manually building a list of all options from BDRVQcowState
values just reuse the options that were used to open the image.
qcow2_open() won't fully use all of the options in the QDict, but that's
okay.

This fixes all of the driver-specific options in qcow2, except for
lazy-refcounts, which was special cased before.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block/qcow2.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/block/qcow2.c b/block/qcow2.c
index da82646..945c9d6 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -1180,11 +1180,8 @@ static void qcow2_invalidate_cache(BlockDriverState *bs)
 
     bdrv_invalidate_cache(bs->file);
 
-    options = qdict_new();
-    qdict_put(options, QCOW2_OPT_LAZY_REFCOUNTS,
-              qbool_from_int(s->use_lazy_refcounts));
-
     memset(s, 0, sizeof(BDRVQcowState));
+    options = qdict_clone_shallow(bs->options);
     qcow2_open(bs, options, flags, NULL);
 
     QDECREF(options);
-- 
1.8.1.4

Re: [Qemu-devel] [PATCH] qcow2: Keep option in qcow2_invalidate_cache()

[Max Reitz]

On 11.03.2014 17:42, Kevin Wolf wrote:
> Instead of manually building a list of all options from BDRVQcowState
> values just reuse the options that were used to open the image.
> qcow2_open() won't fully use all of the options in the QDict, but that's
> okay.
>
> This fixes all of the driver-specific options in qcow2, except for
> lazy-refcounts, which was special cased before.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>   block/qcow2.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>

Re: [Qemu-devel] [PATCH] qcow2: Keep option in qcow2_invalidate_cache()

[Stefan Hajnoczi]

On Tue, Mar 11, 2014 at 05:42:41PM +0100, Kevin Wolf wrote:
> Instead of manually building a list of all options from BDRVQcowState
> values just reuse the options that were used to open the image.
> qcow2_open() won't fully use all of the options in the QDict, but that's
> okay.
> 
> This fixes all of the driver-specific options in qcow2, except for
> lazy-refcounts, which was special cased before.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  block/qcow2.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan