From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46181) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNRgj-0007Uy-0k for qemu-devel@nongnu.org; Tue, 11 Mar 2014 14:46:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNRgd-0002ii-Ja for qemu-devel@nongnu.org; Tue, 11 Mar 2014 14:46:04 -0400 Received: from mail-ee0-x236.google.com ([2a00:1450:4013:c00::236]:55977) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNRgd-0002iX-CW for qemu-devel@nongnu.org; Tue, 11 Mar 2014 14:45:59 -0400 Received: by mail-ee0-f54.google.com with SMTP id d49so3930761eek.27 for ; Tue, 11 Mar 2014 11:45:58 -0700 (PDT) Date: Tue, 11 Mar 2014 19:45:55 +0100 From: Stefan Hajnoczi Message-ID: <20140311184555.GB512@stefanha-thinkpad.redhat.com> References: <1394547303-9154-1-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1394547303-9154-1-git-send-email-kwolf@redhat.com> Subject: Re: [Qemu-devel] [PATCH] qcow2: Don't write with BDRV_O_INCOMING List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, stefanha@redhat.com On Tue, Mar 11, 2014 at 03:15:03PM +0100, Kevin Wolf wrote: > qcow2_open() causes writes when repairing an image with the dirty flag > set and when clearing autoclear flags. It shouldn't do this when another > qemu instance is still actively working on this image file. > > One effect of the bug is that images may have a cleared dirty flag while > the migration source host still has it in use with lazy refcounts > enabled, so refcounts are not accurate and the dirty flag must remain > set. > > Signed-off-by: Kevin Wolf > --- > block/qcow2.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan