From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48207) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNRmL-0003Ik-UY for qemu-devel@nongnu.org; Tue, 11 Mar 2014 14:52:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNRmD-00052x-Hy for qemu-devel@nongnu.org; Tue, 11 Mar 2014 14:51:53 -0400 Received: from mail-ea0-x230.google.com ([2a00:1450:4013:c01::230]:58849) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNRmD-00052g-Bo for qemu-devel@nongnu.org; Tue, 11 Mar 2014 14:51:45 -0400 Received: by mail-ea0-f176.google.com with SMTP id o10so4427003eaj.21 for ; Tue, 11 Mar 2014 11:51:44 -0700 (PDT) Date: Tue, 11 Mar 2014 19:51:41 +0100 From: Stefan Hajnoczi Message-ID: <20140311185141.GD512@stefanha-thinkpad.redhat.com> References: <1394542834-31741-1-git-send-email-marcel.a@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1394542834-31741-1-git-send-email-marcel.a@redhat.com> Subject: Re: [Qemu-devel] [PATCH V4] tests/libqtest: Fix possible deadlock in qtest initialization List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum Cc: kwolf@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, aliguori@amazon.com, afaerber@suse.de On Tue, Mar 11, 2014 at 03:00:34PM +0200, Marcel Apfelbaum wrote: > 'socket_accept' waits for Qemu to init its unix socket. > If Qemu encounters an error during command line parsing, > it can exit before initializing the communication channel. > > Using a timeout for sockets fixes the issue. > > Reviewed-by: Eric Blake > Signed-off-by: Marcel Apfelbaum > --- > tests/libqtest.c | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) Reviewed-by: Stefan Hajnoczi