From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35682) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNSdc-0008KG-Pu for qemu-devel@nongnu.org; Tue, 11 Mar 2014 15:47:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNSdW-0008Qe-RJ for qemu-devel@nongnu.org; Tue, 11 Mar 2014 15:46:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14787) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNSdW-0008QZ-JB for qemu-devel@nongnu.org; Tue, 11 Mar 2014 15:46:50 -0400 Date: Tue, 11 Mar 2014 19:46:40 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20140311194640.GN2450@work-vm> References: <1394392713-31471-1-git-send-email-mst@redhat.com> <1394392713-31471-9-git-send-email-mst@redhat.com> <531F2C52.50401@siemens.com> <531F3083.9090304@siemens.com> <20140311161301.GG2450@work-vm> <20140311163657.GH2450@work-vm> <20140311183922.GB10982@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140311183922.GB10982@redhat.com> Subject: Re: [Qemu-devel] [PATCH] qemu-thread-posix: Fix build against older glibc version List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Kevin Wolf , Peter Maydell , Stefan Hajnoczi , Jan Kiszka , QEMU Developers , Gerd Hoffmann , Anthony Liguori , Laszlo Ersek * Michael S. Tsirkin (mst@redhat.com) wrote: > Shouldn't we prevent the unsupported option from > appearing in qemu output though? > Otherwise how does user know whether it works? I'll make it spit a warning if you try and enable it on a platform that doesn't have a way of doing it; ifdef all the option parsing would just make everywhere messy and in the end we defined it as a debug option. Dave -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK