From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38899) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNStU-0005gd-ON for qemu-devel@nongnu.org; Tue, 11 Mar 2014 16:03:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNStO-000598-LA for qemu-devel@nongnu.org; Tue, 11 Mar 2014 16:03:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21725) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNStO-00058e-Do for qemu-devel@nongnu.org; Tue, 11 Mar 2014 16:03:14 -0400 Date: Tue, 11 Mar 2014 22:03:10 +0200 From: "Michael S. Tsirkin" Message-ID: <20140311200310.GC10982@redhat.com> References: <531F2C52.50401@siemens.com> <531F3083.9090304@siemens.com> <20140311161301.GG2450@work-vm> <20140311163657.GH2450@work-vm> <20140311183922.GB10982@redhat.com> <20140311194640.GN2450@work-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] qemu-thread-posix: Fix build against older glibc version List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Kevin Wolf , Stefan Hajnoczi , Jan Kiszka , "Dr. David Alan Gilbert" , QEMU Developers , Gerd Hoffmann , Anthony Liguori , Laszlo Ersek On Tue, Mar 11, 2014 at 07:53:20PM +0000, Peter Maydell wrote: > On 11 March 2014 19:46, Dr. David Alan Gilbert wrote: > > * Michael S. Tsirkin (mst@redhat.com) wrote: > > > >> Shouldn't we prevent the unsupported option from > >> appearing in qemu output though? > >> Otherwise how does user know whether it works? > > > > I'll make it spit a warning if you try and enable it on a platform > > that doesn't have a way of doing it; ifdef all the option parsing > > would just make everywhere messy and in the end we defined it > > as a debug option. > > When would you want to not enable it? If this is > purely for debug convenience why not just have "always > set thread names if the platform allows it" ? > > thanks > -- PMM Because we don't want people to start relying on thread naming to manage the threads outside qemu. Then we won't be able to change the threading model. In particular that was the reason we don't have a monitor command to expose thread IDs for threads except VCPUs (for which the reasoning is 1 thread per VCPU is the only thing allowed by KVM). There also can be existing tools that would break if we changed thread names. -- MST