From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42451) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNegv-0002ne-57 for qemu-devel@nongnu.org; Wed, 12 Mar 2014 04:39:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNegp-0006wX-5z for qemu-devel@nongnu.org; Wed, 12 Mar 2014 04:39:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32361) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNego-0006wR-UG for qemu-devel@nongnu.org; Wed, 12 Mar 2014 04:39:03 -0400 Date: Wed, 12 Mar 2014 09:38:56 +0100 From: Stefan Hajnoczi Message-ID: <20140312083856.GD17763@stefanha-thinkpad.muc.redhat.com> References: <1394542834-31741-1-git-send-email-marcel.a@redhat.com> <20140311185141.GD512@stefanha-thinkpad.redhat.com> <1394565655.3981.61.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1394565655.3981.61.camel@localhost.localdomain> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V4] tests/libqtest: Fix possible deadlock in qtest initialization List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum Cc: kwolf@redhat.com, Stefan Hajnoczi , qemu-devel@nongnu.org, armbru@redhat.com, aliguori@amazon.com, afaerber@suse.de On Tue, Mar 11, 2014 at 09:20:55PM +0200, Marcel Apfelbaum wrote: > On Tue, 2014-03-11 at 19:51 +0100, Stefan Hajnoczi wrote: > > On Tue, Mar 11, 2014 at 03:00:34PM +0200, Marcel Apfelbaum wrote: > > > 'socket_accept' waits for Qemu to init its unix socket. > > > If Qemu encounters an error during command line parsing, > > > it can exit before initializing the communication channel. > > >=20 > > > Using a timeout for sockets fixes the issue. > > >=20 > > > Reviewed-by: Eric Blake > > > Signed-off-by: Marcel Apfelbaum > > > --- > > > tests/libqtest.c | 13 +++++++++++-- > > > 1 file changed, 11 insertions(+), 2 deletions(-) > >=20 > > Reviewed-by: Stefan Hajnoczi >=20 > Thanks for the help, Stefan! > Please be aware that until you take care of the > "abort during qtest_init" issue, qtest will crash > on such occasions. >=20 > Last thing, which maintainer should take this? Andreas F=E4rber is the most likely victim^H^H^H^H^H^Hmaintainer: "I don't feel like the official qtest maintainer, but I care and am actively working on it. I would consider it best to have individual tests maintained by subsystem maintainers and only define a maintainer for the core libqtest.c/qtest.c code." Although I'm interested in libqtest myself I don't have the bandwidth to review/merge all future patches in that area. Stefan