From: Stefan Hajnoczi <stefanha@gmail.com>
To: Max Reitz <mreitz@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
qemu-devel@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
"Benoît Canet" <benoit@irqsave.net>
Subject: Re: [Qemu-devel] [PATCH] block: Unlink temporary file
Date: Wed, 12 Mar 2014 10:15:55 +0100 [thread overview]
Message-ID: <20140312091555.GA18850@stefanha-thinkpad.muc.redhat.com> (raw)
In-Reply-To: <1392483801-15830-1-git-send-email-mreitz@redhat.com>
On Sat, Feb 15, 2014 at 06:03:21PM +0100, Max Reitz wrote:
> If the image file cannot be opened and was created as a temporary file,
> it should be deleted; thus, in this case, we should jump to the
> "unlink_and_fail" label and not just to "fail".
>
> Reported-by: Benoît Canet <benoit@irqsave.net>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> This patch's context depends on my bdrv_open()/bdrv_file_open() series
> ("[PATCH v3 0/8] block: Integrate bdrv_file_open() into bdrv_open()").
> ---
> block.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
prev parent reply other threads:[~2014-03-12 9:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-15 17:03 [Qemu-devel] [PATCH] block: Unlink temporary file Max Reitz
2014-02-17 10:12 ` Stefan Hajnoczi
2014-03-12 9:15 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140312091555.GA18850@stefanha-thinkpad.muc.redhat.com \
--to=stefanha@gmail.com \
--cc=benoit@irqsave.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).