From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58295) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNfe4-0007BD-UK for qemu-devel@nongnu.org; Wed, 12 Mar 2014 05:40:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNfdv-0003Eb-Hn for qemu-devel@nongnu.org; Wed, 12 Mar 2014 05:40:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38436) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNfdv-0003CK-Ai for qemu-devel@nongnu.org; Wed, 12 Mar 2014 05:40:07 -0400 Date: Wed, 12 Mar 2014 10:40:00 +0100 From: Kevin Wolf Message-ID: <20140312094000.GA2662@dhcp-200-207.str.redhat.com> References: <1394531919-14346-1-git-send-email-kwolf@redhat.com> <20140311164145.GC3276@irqsave.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20140311164145.GC3276@irqsave.net> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] block: Update image size in bdrv_invalidate_cache() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Beno=EEt?= Canet Cc: qemu-devel@nongnu.org, stefanha@redhat.com, quintela@redhat.com Am 11.03.2014 um 17:41 hat Beno=EEt Canet geschrieben: > I have the impression that you are silently fixing other nits; Am I? Not intentionally at least. I think I can justify every single line of the patch with respect to the bug described in the commit message. We need to recursive into the protocol layer, and we need to refresh bs->total_sectors. For drivers implementing the callback, we need to recurse to bs->file between the internal open/close pair. I can't see what could be left out in this patch. Kevin