From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58889)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1WNfhK-0000t8-UD
	for qemu-devel@nongnu.org; Wed, 12 Mar 2014 05:43:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1WNfhE-0004PS-0V
	for qemu-devel@nongnu.org; Wed, 12 Mar 2014 05:43:38 -0400
Received: from lnantes-156-75-100-125.w80-12.abo.wanadoo.fr
	([80.12.84.125]:56076 helo=paradis.irqsave.net)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1WNfhD-0004Ov-Qv
	for qemu-devel@nongnu.org; Wed, 12 Mar 2014 05:43:31 -0400
Date: Wed, 12 Mar 2014 10:43:30 +0100
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Message-ID: <20140312094330.GA3245@irqsave.net>
References: <1394531919-14346-1-git-send-email-kwolf@redhat.com>
	<20140311164145.GC3276@irqsave.net>
	<20140312094000.GA2662@dhcp-200-207.str.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <20140312094000.GA2662@dhcp-200-207.str.redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] block: Update image size in
 bdrv_invalidate_cache()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>, qemu-devel@nongnu.org, stefanha@redhat.com, quintela@redhat.com

The Wednesday 12 Mar 2014 =E0 10:40:00 (+0100), Kevin Wolf wrote :
> Am 11.03.2014 um 17:41 hat Beno=EEt Canet geschrieben:
> > I have the impression that you are silently fixing other nits;
>=20
> Am I?
>=20
> Not intentionally at least. I think I can justify every single line of
> the patch with respect to the bug described in the commit message. We
> need to recursive into the protocol layer, and we need to refresh
> bs->total_sectors. For drivers implementing the callback, we need to
> recurse to bs->file between the internal open/close pair.
>=20
> I can't see what could be left out in this patch.

I didn't understood the implication on recursion at first sight.

Best regards

Beno=EEt

>=20
> Kevin
>=20