From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38353) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNlHN-0003Cx-JS for qemu-devel@nongnu.org; Wed, 12 Mar 2014 11:41:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNlHI-0002Th-4Y for qemu-devel@nongnu.org; Wed, 12 Mar 2014 11:41:13 -0400 Date: Wed, 12 Mar 2014 11:41:07 -0400 From: Mike Day Message-ID: <20140312154107.GD10381@pixel.localdomain> References: <1385006938-32515-1-git-send-email-aik@ozlabs.ru> <1385006938-32515-5-git-send-email-aik@ozlabs.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1385006938-32515-5-git-send-email-aik@ozlabs.ru> Subject: Re: [Qemu-devel] spapr-pci: converts fprintf to error_report List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Alexander Graf On 21/11/13 15:08 +1100, Alexey Kardashevskiy wrote: > Signed-off-by: Alexey Kardashevskiy Reviewed-by: Mike Day > --- > hw/ppc/spapr_pci.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c > index 963841c..d102d82 100644 > --- a/hw/ppc/spapr_pci.c > +++ b/hw/ppc/spapr_pci.c > @@ -293,7 +293,7 @@ static void rtas_ibm_change_msi(PowerPCCPU *cpu, sPAPREnvironment *spapr, > ret_intr_type = RTAS_TYPE_MSIX; > break; > default: > - fprintf(stderr, "rtas_ibm_change_msi(%u) is not implemented\n", func); > + error_report("rtas_ibm_change_msi(%u) is not implemented", func); > rtas_st(rets, 0, RTAS_OUT_PARAM_ERROR); > return; > } > @@ -327,7 +327,7 @@ static void rtas_ibm_change_msi(PowerPCCPU *cpu, sPAPREnvironment *spapr, > /* Find a device number in the map to add or reuse the existing one */ > ndev = spapr_msicfg_find(phb, config_addr, true); > if (ndev >= SPAPR_MSIX_MAX_DEVS || ndev < 0) { > - fprintf(stderr, "No free entry for a new MSI device\n"); > + error_report("No free entry for a new MSI device"); > rtas_st(rets, 0, RTAS_OUT_HW_ERROR); > return; > } > @@ -336,7 +336,7 @@ static void rtas_ibm_change_msi(PowerPCCPU *cpu, sPAPREnvironment *spapr, > /* Check if there is an old config and MSI number has not changed */ > if (phb->msi_table[ndev].nvec && (req_num != phb->msi_table[ndev].nvec)) { > /* Unexpected behaviour */ > - fprintf(stderr, "Cannot reuse MSI config for device#%d", ndev); > + error_report("Cannot reuse MSI config for device#%d", ndev); > rtas_st(rets, 0, RTAS_OUT_HW_ERROR); > return; > } > @@ -346,7 +346,7 @@ static void rtas_ibm_change_msi(PowerPCCPU *cpu, sPAPREnvironment *spapr, > irq = spapr_allocate_irq_block(req_num, false, > ret_intr_type == RTAS_TYPE_MSI); > if (irq < 0) { > - fprintf(stderr, "Cannot allocate MSIs for device#%d", ndev); > + error_report("Cannot allocate MSIs for device#%d", ndev); > rtas_st(rets, 0, RTAS_OUT_HW_ERROR); > return; > } > -- > 1.8.4.rc4 > > > >