From: Stefan Hajnoczi <stefanha@redhat.com>
To: Pankaj Gupta <pagupta@redhat.com>
Cc: qemu-devel@nongnu.org, aliguori@amazon.com
Subject: Re: [Qemu-devel] [PATCH] Avoiding extra iterations while closing file fd
Date: Thu, 13 Mar 2014 13:48:09 +0100 [thread overview]
Message-ID: <20140313124809.GA15090@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1394643267-1194-1-git-send-email-pagupta@redhat.com>
On Wed, Mar 12, 2014 at 10:24:27PM +0530, Pankaj Gupta wrote:
> Avoiding iterations for fd 0, 1 & 2 when we are closing file fds in child process.
>
> Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
> ---
> net/tap.c | 14 ++++----------
> 1 file changed, 4 insertions(+), 10 deletions(-)
POSIX defines the values of standard in, out, and error as 0, 1, and 2
constants. So this patch is correct but it doesn't do anything useful.
This is something compiler can optimize (but speed doesn't even matter
here).
Please try to focus on patches that fix bugs, add features, or otherwise
add value - it takes the community time to review, test, and merge
patches.
Thanks, applied to my net-next tree:
https://github.com/stefanha/qemu/commits/net-next
Stefan
prev parent reply other threads:[~2014-03-13 12:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 16:54 [Qemu-devel] [PATCH] Avoiding extra iterations while closing file fd Pankaj Gupta
2014-03-13 12:48 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140313124809.GA15090@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=aliguori@amazon.com \
--cc=pagupta@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).