From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53494) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WO5j0-0006sU-2F for qemu-devel@nongnu.org; Thu, 13 Mar 2014 09:31:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WO5ir-0008LA-Rt for qemu-devel@nongnu.org; Thu, 13 Mar 2014 09:31:06 -0400 Received: from lputeaux-656-01-25-125.w80-12.abo.wanadoo.fr ([80.12.84.125]:56120 helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WO5ir-0008L6-JA for qemu-devel@nongnu.org; Thu, 13 Mar 2014 09:30:57 -0400 Date: Thu, 13 Mar 2014 14:30:57 +0100 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20140313133057.GD4534@irqsave.net> References: <1394605864-32237-1-git-send-email-famz@redhat.com> <1394605864-32237-5-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1394605864-32237-5-git-send-email-famz@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 4/9] block: Introduce bdrv_dirty_bitmap_granularity() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com The Wednesday 12 Mar 2014 =E0 14:30:59 (+0800), Fam Zheng wrote : > This returns the granularity (in sectors) of dirty bitmap. >=20 > Signed-off-by: Fam Zheng > --- > block.c | 6 ++++++ > include/block/block.h | 2 ++ > 2 files changed, 8 insertions(+) >=20 > diff --git a/block.c b/block.c > index 9de1385..26a43eb 100644 > --- a/block.c > +++ b/block.c > @@ -5143,6 +5143,12 @@ int bdrv_get_dirty(BlockDriverState *bs, BdrvDir= tyBitmap *bitmap, int64_t sector > } > } > =20 > +int bdrv_dirty_bitmap_granularity(BlockDriverState *bs, > + BdrvDirtyBitmap *bitmap) > +{ > + return hbitmap_granularity(bitmap->bitmap); > +} > + > void bdrv_dirty_iter_init(BlockDriverState *bs, > BdrvDirtyBitmap *bitmap, HBitmapIter *hbi) > { > diff --git a/include/block/block.h b/include/block/block.h > index aa0c5e4..b87c071 100644 > --- a/include/block/block.h > +++ b/include/block/block.h > @@ -446,6 +446,8 @@ BdrvDirtyBitmap *bdrv_find_dirty_bitmap(BlockDriver= State *bs, > void bdrv_dirty_bitmap_make_anon(BlockDriverState *bs, BdrvDirtyBitmap= *bitmap); > void bdrv_release_dirty_bitmap(BlockDriverState *bs, BdrvDirtyBitmap *= bitmap); > BlockDirtyInfoList *bdrv_query_dirty_bitmaps(BlockDriverState *bs); > +int bdrv_dirty_bitmap_granularity(BlockDriverState *bs, > + BdrvDirtyBitmap *bitmap); > int bdrv_get_dirty(BlockDriverState *bs, BdrvDirtyBitmap *bitmap, int6= 4_t sector); > void bdrv_set_dirty(BlockDriverState *bs, int64_t cur_sector, int nr_s= ectors); > void bdrv_reset_dirty(BlockDriverState *bs, int64_t cur_sector, int nr= _sectors); > --=20 > 1.9.0 >=20 >=20 Reviewed-by: Benoit Canet