From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45975)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rjones@redhat.com>) id 1WO8UH-0001Qb-DH
	for qemu-devel@nongnu.org; Thu, 13 Mar 2014 12:28:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rjones@redhat.com>) id 1WO8UC-0005LO-OX
	for qemu-devel@nongnu.org; Thu, 13 Mar 2014 12:28:05 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53999)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rjones@redhat.com>) id 1WO8UC-0005L9-Gi
	for qemu-devel@nongnu.org; Thu, 13 Mar 2014 12:28:00 -0400
Date: Thu, 13 Mar 2014 16:27:50 +0000
From: "Richard W.M. Jones" <rjones@redhat.com>
Message-ID: <20140313162750.GF1346@redhat.com>
References: <1394727876-23310-1-git-send-email-afaerber@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <1394727876-23310-1-git-send-email-afaerber@suse.de>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH qom-next] virtio-console: Fix
	VIRTIO_CONSOLE() cast macro
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>
Cc: Amit Shah <amit.shah@redhat.com>, qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>, "Michael S. Tsirkin" <mst@redhat.com>

On Thu, Mar 13, 2014 at 05:24:36PM +0100, Andreas F=E4rber wrote:
> Commit 0399a3819b27083ba69b88a9baa9025facab85bd (virtio-console: QOM
> cast cleanup for VirtConsole) broke virtserialport since it shares
> functions and state struct with virtconsole. Let virtconsole inherit
> from virtserialport, and use virtserialport type for casting.
>=20
> Note that virtio-serial-port is the abstract base type in
> virtio-serial-bus.c, whereas virtserialport is the user-instantiatable
> type in virtio-console.c. Therefore using TYPE_VIRTIO_CONSOLE_SERIAL_PO=
RT.
>=20
> Reported-by: Richard W.M. Jones <rjones@redhat.com>
> Signed-off-by: Andreas F=E4rber <afaerber@suse.de>

This patch fixes the problem for me, thanks.

ACK.

Rich.

--=20
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rj=
ones
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org