From: Stefan Hajnoczi <stefanha@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>,
Stefan Weil <sw@weilnetz.de>
Subject: Re: [Qemu-devel] [PATCH] Makefile: Don't find and delete when $(DSOSUF) is empty in "make clean"
Date: Fri, 14 Mar 2014 13:13:19 +0100 [thread overview]
Message-ID: <20140314121319.GA25577@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1394786300-18017-1-git-send-email-famz@redhat.com>
On Fri, Mar 14, 2014 at 04:38:20PM +0800, Fam Zheng wrote:
> DANGEROUS: don't try it before you read to the end.
>
> A first "make distclean" will unset $(DSOSUF), a following "make
> distclean" or "make clean" will find all the files and delete it.
>
> Including all the files in the .git directory!
>
> Fix it by only do it when $(DSOSUF) is not empty.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
next prev parent reply other threads:[~2014-03-14 12:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 8:38 [Qemu-devel] [PATCH] Makefile: Don't find and delete when $(DSOSUF) is empty in "make clean" Fam Zheng
2014-03-14 12:13 ` Stefan Hajnoczi [this message]
2014-03-14 17:49 ` Stefan Weil
2014-03-17 1:34 ` Fam Zheng
2014-03-17 8:30 ` Markus Armbruster
2014-03-17 18:51 ` Andreas Färber
2014-03-17 19:15 ` Peter Maydell
2014-03-18 9:19 ` Markus Armbruster
2014-03-18 8:24 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140314121319.GA25577@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=famz@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).