From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49305)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WOQzV-0003aE-F5
	for qemu-devel@nongnu.org; Fri, 14 Mar 2014 08:13:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WOQzP-0003CH-GD
	for qemu-devel@nongnu.org; Fri, 14 Mar 2014 08:13:33 -0400
Received: from mx1.redhat.com ([209.132.183.28]:5973)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WOQzP-0003CA-97
	for qemu-devel@nongnu.org; Fri, 14 Mar 2014 08:13:27 -0400
Date: Fri, 14 Mar 2014 13:13:19 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20140314121319.GA25577@stefanha-thinkpad.redhat.com>
References: <1394786300-18017-1-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1394786300-18017-1-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Makefile: Don't find and delete when
 $(DSOSUF) is empty in "make clean"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>, Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, Stefan Weil <sw@weilnetz.de>

On Fri, Mar 14, 2014 at 04:38:20PM +0800, Fam Zheng wrote:
> DANGEROUS: don't try it before you read to the end.
> 
> A first "make distclean" will unset $(DSOSUF), a following "make
> distclean" or "make clean" will find all the files and delete it.
> 
> Including all the files in the .git directory!
> 
> Fix it by only do it when $(DSOSUF) is not empty.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>