qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Aakriti Gupta <aakritty@gmail.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] convert fprintf() calls to error_setg() in block/qed.c:bdrv_qed_create()
Date: Fri, 14 Mar 2014 15:23:57 +0100	[thread overview]
Message-ID: <20140314142357.GB5678@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <CALRrUAFB9ad84JSXFqhWaegzKm3+BWM0vpNx8ceDRAG1f_iffQ@mail.gmail.com>

On Fri, Mar 14, 2014 at 06:05:47PM +0530, Aakriti Gupta wrote:
> @@ -650,18 +650,18 @@ static int bdrv_qed_create(const char *filename,
> QEMUOptionParameter *options,

I just noticed that the email is line-wrapped.

Please do not copy-paste patches into GMail.  The GMail web interface
always wraps lines, there is no way to disable this and it breaks
git-am(1) so I cannot apply the patch.

Instead, please use git-send-email(1):
"We recommend git send-email because mail clients often mangle patches
by wrapping long lines or messing up whitespace"
http://qemu-project.org/Contribute/SubmitAPatch

Stefan

      parent reply	other threads:[~2014-03-14 14:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-14 12:35 [Qemu-devel] [PATCH] convert fprintf() calls to error_setg() in block/qed.c:bdrv_qed_create() Aakriti Gupta
2014-03-14 14:21 ` Stefan Hajnoczi
2014-03-14 14:23 ` Stefan Hajnoczi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140314142357.GB5678@stefanha-thinkpad.redhat.com \
    --to=stefanha@gmail.com \
    --cc=aakritty@gmail.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).