From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45314)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WOT1q-00038i-4U
	for qemu-devel@nongnu.org; Fri, 14 Mar 2014 10:24:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WOT1k-0001NA-Oy
	for qemu-devel@nongnu.org; Fri, 14 Mar 2014 10:24:06 -0400
Received: from mail-ee0-x22d.google.com ([2a00:1450:4013:c00::22d]:45419)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WOT1k-0001N4-IT
	for qemu-devel@nongnu.org; Fri, 14 Mar 2014 10:24:00 -0400
Received: by mail-ee0-f45.google.com with SMTP id d17so1438432eek.18
	for <qemu-devel@nongnu.org>; Fri, 14 Mar 2014 07:23:59 -0700 (PDT)
Date: Fri, 14 Mar 2014 15:23:57 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20140314142357.GB5678@stefanha-thinkpad.redhat.com>
References: <CALRrUAFB9ad84JSXFqhWaegzKm3+BWM0vpNx8ceDRAG1f_iffQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALRrUAFB9ad84JSXFqhWaegzKm3+BWM0vpNx8ceDRAG1f_iffQ@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] convert fprintf() calls to error_setg() in
 block/qed.c:bdrv_qed_create()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aakriti Gupta <aakritty@gmail.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On Fri, Mar 14, 2014 at 06:05:47PM +0530, Aakriti Gupta wrote:
> @@ -650,18 +650,18 @@ static int bdrv_qed_create(const char *filename,
> QEMUOptionParameter *options,

I just noticed that the email is line-wrapped.

Please do not copy-paste patches into GMail.  The GMail web interface
always wraps lines, there is no way to disable this and it breaks
git-am(1) so I cannot apply the patch.

Instead, please use git-send-email(1):
"We recommend git send-email because mail clients often mangle patches
by wrapping long lines or messing up whitespace"
http://qemu-project.org/Contribute/SubmitAPatch

Stefan