From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34689) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WOUAC-0003GN-Bl for qemu-devel@nongnu.org; Fri, 14 Mar 2014 11:36:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WOUA7-0003TK-Fi for qemu-devel@nongnu.org; Fri, 14 Mar 2014 11:36:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6897) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WOUA7-0003TC-6y for qemu-devel@nongnu.org; Fri, 14 Mar 2014 11:36:43 -0400 Date: Fri, 14 Mar 2014 15:36:39 +0000 From: "Richard W.M. Jones" Message-ID: <20140314153639.GD1985@redhat.com> References: <3096076082478dafe78553ab5cbd8b572904cbc4.1394794127.git.jcody@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3096076082478dafe78553ab5cbd8b572904cbc4.1394794127.git.jcody@redhat.com> Subject: Re: [Qemu-devel] [PATCH] block: Explicitly specify 'unsigned long long' for VHDX 64-bit constants List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, agraf@suse.de On Fri, Mar 14, 2014 at 06:50:37AM -0400, Jeff Cody wrote: > On 32-bit hosts, some compilers will warn on too large integer constants > for constants that are 64-bit in length. Explicitly put a 'ULL' suffix > on those defines. > -#define VHDX_FILE_SIGNATURE 0x656C696678646876 /* "vhdxfile" in ASCII */ > +#define VHDX_FILE_SIGNATURE 0x656C696678646876ULL /* "vhdxfile" in ASCII */ I think it's better to use this C99-defined feature (from ): #define VHDX_FILE_SIGNATURE UINT64_C(0x656C696678646876) Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org