Re: [Qemu-devel] [PATCH 0/2] dataplane: fix bogus coverity warnings

[Stefan Hajnoczi <stefanha@redhat.com>]

On Fri, Mar 14, 2014 at 06:25:34PM +0100, Paolo Bonzini wrote:
> Il 14/03/2014 16:14, Stefan Hajnoczi ha scritto:
> >Coverity detects when variable are accessed under a mutex most of the time.  It
> >warns when they are not accessed under the mutex.  I initialized variables
> >before the mutex and threads that access them even exist - Coverity doesn't
> >like that.  Fix the code.
> >
> >Stefan Hajnoczi (2):
> >  iothread: fix bogus coverity warning
> >  rfifolock: fix bogus coverity warning
> >
> > iothread.c       | 5 ++++-
> > util/rfifolock.c | 4 +++-
> > 2 files changed, 7 insertions(+), 2 deletions(-)
> >
> 
> Nah, I think Coverity is wrong.  It should detect initialization of
> the mutex, and treat surrounding code as single-threaded.  I
> silenced the defects in the report, like others before.

Okay, let's drop these patches.

Stefan