From: Stefan Hajnoczi <stefanha@redhat.com>
To: Aakriti Gupta <aakritty@gmail.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] convert fprintf() calls to error_setg() in block/qed.c:bdrv_qed_create()
Date: Mon, 17 Mar 2014 15:59:48 +0100 [thread overview]
Message-ID: <20140317145948.GG4888@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1394876123-8902-1-git-send-email-aakritty@gmail.com>
On Sat, Mar 15, 2014 at 03:05:23PM +0530, Aakriti Gupta wrote:
> This patch converts fprintf() calls to error_setg() in block/qed.c:bdrv_qed_create()
> (error_setg() is part of error reporting API in include/qapi/error.h)
>
> Signed-off-by: Aakriti Gupta <aakritty@gmail.com>
> ---
> block/qed.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
> if (!qed_is_cluster_size_valid(cluster_size)) {
> - fprintf(stderr, "QED cluster size must be within range [%u, %u] and power of 2\n",
> + error_setg(errp, "QED cluster size must be within range [%u, %u] and power of 2",
> QED_MIN_CLUSTER_SIZE, QED_MAX_CLUSTER_SIZE);
Kevin: Do you want to fix up the indentation of the next line when
merging?
next prev parent reply other threads:[~2014-03-17 15:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-15 9:35 [Qemu-devel] [PATCH v2] convert fprintf() calls to error_setg() in block/qed.c:bdrv_qed_create() Aakriti Gupta
2014-03-17 14:59 ` Stefan Hajnoczi [this message]
2014-03-18 9:44 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140317145948.GG4888@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=aakritty@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).