From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36476)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WPZ1I-0005ZI-Hi
	for qemu-devel@nongnu.org; Mon, 17 Mar 2014 11:00:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WPZ17-0001S7-NE
	for qemu-devel@nongnu.org; Mon, 17 Mar 2014 11:00:04 -0400
Received: from mx1.redhat.com ([209.132.183.28]:62767)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WPZ16-0001Rk-Qx
	for qemu-devel@nongnu.org; Mon, 17 Mar 2014 10:59:53 -0400
Date: Mon, 17 Mar 2014 15:59:48 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20140317145948.GG4888@stefanha-thinkpad.redhat.com>
References: <1394876123-8902-1-git-send-email-aakritty@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1394876123-8902-1-git-send-email-aakritty@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2] convert fprintf() calls to error_setg()
 in block/qed.c:bdrv_qed_create()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aakriti Gupta <aakritty@gmail.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org

On Sat, Mar 15, 2014 at 03:05:23PM +0530, Aakriti Gupta wrote:
> This patch converts fprintf() calls to error_setg() in block/qed.c:bdrv_qed_create()
> (error_setg() is part of error reporting API in include/qapi/error.h)
> 
> Signed-off-by: Aakriti Gupta <aakritty@gmail.com>
> ---
>  block/qed.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Acked-by: Stefan Hajnoczi <stefanha@redhat.com>

>      if (!qed_is_cluster_size_valid(cluster_size)) {
> -        fprintf(stderr, "QED cluster size must be within range [%u, %u] and power of 2\n",
> +        error_setg(errp, "QED cluster size must be within range [%u, %u] and power of 2",
>                  QED_MIN_CLUSTER_SIZE, QED_MAX_CLUSTER_SIZE);

Kevin: Do you want to fix up the indentation of the next line when
merging?