From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39532) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPZDI-0006iG-EC for qemu-devel@nongnu.org; Mon, 17 Mar 2014 11:12:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WPZDD-0005px-Eb for qemu-devel@nongnu.org; Mon, 17 Mar 2014 11:12:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23311) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPZDD-0005pn-71 for qemu-devel@nongnu.org; Mon, 17 Mar 2014 11:12:23 -0400 Date: Mon, 17 Mar 2014 16:12:16 +0100 From: Stefan Hajnoczi Message-ID: <20140317151216.GI4888@stefanha-thinkpad.redhat.com> References: <1395004259-12551-1-git-send-email-maria.k@catit.be> <1395004259-12551-3-git-send-email-maria.k@catit.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1395004259-12551-3-git-send-email-maria.k@catit.be> Subject: Re: [Qemu-devel] [PATCH 2/3] block: Replaced old error handling with error reporting API. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Maria Kustova Cc: kwolf@redhat.com, qemu-devel@nongnu.org, Maria Kustova On Mon, Mar 17, 2014 at 01:10:58AM +0400, Maria Kustova wrote: > Signed-off-by: Maria Kustova > --- > block/curl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/curl.c b/block/curl.c > index 3494c6d..359637e 100644 > --- a/block/curl.c > +++ b/block/curl.c > @@ -538,7 +538,7 @@ static int curl_open(BlockDriverState *bs, QDict *options, int flags, > return 0; > > out: > - fprintf(stderr, "CURL: Error opening file: %s\n", state->errmsg); > + error_setg(errp, "CURL: Error opening file: %s\n", state->errmsg); error_setg() does not require newline at the end of the line. Please remove the '\n'.