From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47834) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPp7W-00012o-PK for qemu-devel@nongnu.org; Tue, 18 Mar 2014 04:11:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WPp7N-0004n4-Ji for qemu-devel@nongnu.org; Tue, 18 Mar 2014 04:11:34 -0400 Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:57415) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPp7N-0004mG-9Z for qemu-devel@nongnu.org; Tue, 18 Mar 2014 04:11:25 -0400 Received: from /spool/local by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 18 Mar 2014 08:11:22 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 760672190041 for ; Tue, 18 Mar 2014 08:11:15 +0000 (GMT) Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com [9.149.37.229]) by b06cxnps4076.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s2I8B8wp43712596 for ; Tue, 18 Mar 2014 08:11:08 GMT Received: from d06av05.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s2I8BJgA008909 for ; Tue, 18 Mar 2014 02:11:19 -0600 Date: Tue, 18 Mar 2014 09:11:19 +0100 From: Heiko Carstens Message-ID: <20140318081119.GA4311@osiris> References: <1395079899-29239-1-git-send-email-cornelia.huck@de.ibm.com> <1395079899-29239-4-git-send-email-cornelia.huck@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1395079899-29239-4-git-send-email-cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH v2 3/5] KVM: s390: adapter interrupt sources List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: linux-s390@vger.kernel.org, kvm@vger.kernel.org, gleb@kernel.org, agraf@suse.de, qemu-devel@nongnu.org, borntraeger@de.ibm.com, pbonzini@redhat.com On Mon, Mar 17, 2014 at 07:11:37PM +0100, Cornelia Huck wrote: > Add a new interface to register/deregister sources of adapter interrupts > identified by an unique id via the flic. Adapters may also be maskable > and carry a list of pinned pages. > > These adapters will be used by irq routing later. > > Signed-off-by: Cornelia Huck > --- [...] > +#define MAX_S390_IO_ADAPTERS (MAX_ISC + 1) * 8 Subtle possible bug alert ;) Please add braces around (MAX_ISC + 1) * 8.