From: Kevin Wolf <kwolf@redhat.com>
To: Maria Kustova <maxa@catit.be>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
stefanha@redhat.com, Maria Kustova <maria.k@catit.be>
Subject: Re: [Qemu-devel] [PATCH v2 2/3] block: Replaced old error handling with error reporting API.
Date: Tue, 18 Mar 2014 10:20:38 +0100 [thread overview]
Message-ID: <20140318092038.GE4607@noname.str.redhat.com> (raw)
In-Reply-To: <1395122359-28890-3-git-send-email-maria.k@catit.be>
Am 18.03.2014 um 06:59 hat Maria Kustova geschrieben:
> Signed-off-by: Maria Kustova <maria.k@catit.be>
> ---
> Changes v1 -> v2:
> * Removed trailing "\n" from the error string
> ---
> block/curl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/curl.c b/block/curl.c
> index 3494c6d..359637e 100644
> --- a/block/curl.c
> +++ b/block/curl.c
> @@ -538,8 +538,7 @@ static int curl_open(BlockDriverState *bs, QDict *options, int flags,
Did you manually edit this patch? It is corrupted and I had to manually
s/538,8/538,7/ before I could apply it.
Kevin
> return 0;
>
> out:
> - fprintf(stderr, "CURL: Error opening file: %s\n", state->errmsg);
> + error_setg(errp, "CURL: Error opening file: %s", state->errmsg);
> curl_easy_cleanup(state->curl);
> state->curl = NULL;
> out_noclean:
> --
> 1.8.2.1
>
next prev parent reply other threads:[~2014-03-18 9:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 5:59 [Qemu-devel] [PATCH v2 0/3] Trivial patches Maria Kustova
2014-03-18 5:59 ` [Qemu-devel] [PATCH v2 1/3] qemu-io-cmds: Fixed typo in example for writev Maria Kustova
2014-03-18 5:59 ` [Qemu-devel] [PATCH v2 2/3] block: Replaced old error handling with error reporting API Maria Kustova
2014-03-18 9:20 ` Kevin Wolf [this message]
2014-03-18 5:59 ` [Qemu-devel] [PATCH v2 3/3] qemu-io: Extended "--cmd" description in usage text Maria Kustova
2014-03-18 9:19 ` Kevin Wolf
2014-03-18 9:18 ` [Qemu-devel] [PATCH v2 0/3] Trivial patches Kevin Wolf
2014-03-18 9:37 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140318092038.GE4607@noname.str.redhat.com \
--to=kwolf@redhat.com \
--cc=maria.k@catit.be \
--cc=maxa@catit.be \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).