From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPqCY-0007Fw-GM for qemu-devel@nongnu.org; Tue, 18 Mar 2014 05:20:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WPqCT-0001mI-Cl for qemu-devel@nongnu.org; Tue, 18 Mar 2014 05:20:50 -0400 Date: Tue, 18 Mar 2014 10:20:38 +0100 From: Kevin Wolf Message-ID: <20140318092038.GE4607@noname.str.redhat.com> References: <1395122359-28890-1-git-send-email-maria.k@catit.be> <1395122359-28890-3-git-send-email-maria.k@catit.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1395122359-28890-3-git-send-email-maria.k@catit.be> Subject: Re: [Qemu-devel] [PATCH v2 2/3] block: Replaced old error handling with error reporting API. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Maria Kustova Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, stefanha@redhat.com, Maria Kustova Am 18.03.2014 um 06:59 hat Maria Kustova geschrieben: > Signed-off-by: Maria Kustova > --- > Changes v1 -> v2: > * Removed trailing "\n" from the error string > --- > block/curl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/curl.c b/block/curl.c > index 3494c6d..359637e 100644 > --- a/block/curl.c > +++ b/block/curl.c > @@ -538,8 +538,7 @@ static int curl_open(BlockDriverState *bs, QDict *options, int flags, Did you manually edit this patch? It is corrupted and I had to manually s/538,8/538,7/ before I could apply it. Kevin > return 0; > > out: > - fprintf(stderr, "CURL: Error opening file: %s\n", state->errmsg); > + error_setg(errp, "CURL: Error opening file: %s", state->errmsg); > curl_easy_cleanup(state->curl); > state->curl = NULL; > out_noclean: > -- > 1.8.2.1 >