From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40965)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WPqa2-0002gv-5w
	for qemu-devel@nongnu.org; Tue, 18 Mar 2014 05:45:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WPqZw-0001Ge-7i
	for qemu-devel@nongnu.org; Tue, 18 Mar 2014 05:45:06 -0400
Received: from mx1.redhat.com ([209.132.183.28]:18865)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WPqZv-0001GW-W1
	for qemu-devel@nongnu.org; Tue, 18 Mar 2014 05:45:00 -0400
Date: Tue, 18 Mar 2014 10:44:55 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20140318094455.GH4607@noname.str.redhat.com>
References: <1394876123-8902-1-git-send-email-aakritty@gmail.com>
	<20140317145948.GG4888@stefanha-thinkpad.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140317145948.GG4888@stefanha-thinkpad.redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] convert fprintf() calls to error_setg()
 in block/qed.c:bdrv_qed_create()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org, Aakriti Gupta <aakritty@gmail.com>

Am 17.03.2014 um 15:59 hat Stefan Hajnoczi geschrieben:
> On Sat, Mar 15, 2014 at 03:05:23PM +0530, Aakriti Gupta wrote:
> > This patch converts fprintf() calls to error_setg() in block/qed.c:bdrv_qed_create()
> > (error_setg() is part of error reporting API in include/qapi/error.h)
> > 
> > Signed-off-by: Aakriti Gupta <aakritty@gmail.com>
> > ---
> >  block/qed.c |    8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> Acked-by: Stefan Hajnoczi <stefanha@redhat.com>

Thanks, applied to the block-next branch for qemu 2.1.

> >      if (!qed_is_cluster_size_valid(cluster_size)) {
> > -        fprintf(stderr, "QED cluster size must be within range [%u, %u] and power of 2\n",
> > +        error_setg(errp, "QED cluster size must be within range [%u, %u] and power of 2",
> >                  QED_MIN_CLUSTER_SIZE, QED_MAX_CLUSTER_SIZE);
> 
> Kevin: Do you want to fix up the indentation of the next line when
> merging?

Sure, I did that, and wrapped the line at 80 characters, too.

Kevin