From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46049)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WPt7g-0004dt-GT
	for qemu-devel@nongnu.org; Tue, 18 Mar 2014 08:28:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WPt7Y-0002n4-2d
	for qemu-devel@nongnu.org; Tue, 18 Mar 2014 08:28:00 -0400
Received: from mail-ee0-x230.google.com ([2a00:1450:4013:c00::230]:52639)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WPt7X-0002mn-RN
	for qemu-devel@nongnu.org; Tue, 18 Mar 2014 08:27:51 -0400
Received: by mail-ee0-f48.google.com with SMTP id b57so4600647eek.7
	for <qemu-devel@nongnu.org>; Tue, 18 Mar 2014 05:27:50 -0700 (PDT)
Date: Tue, 18 Mar 2014 13:27:47 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20140318122747.GA9580@stefanha-thinkpad.redhat.com>
References: <1394052684-14362-1-git-send-email-stefanha@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1394052684-14362-1-git-send-email-stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 0/5] qom: link property fixes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>, Andreas Faerber <afaerber@suse.de>

On Wed, Mar 05, 2014 at 09:51:19PM +0100, Stefan Hajnoczi wrote:
> v3:
>  * Split first commit for easier reviewing [afaerber]
>  * Turn bool argument into flags bitmask [pbonzini]
>  * Rename set() callback to check() [pbonzini]
>  * Rename object_property_default_set_link() to
>    object_property_allow_set_link()
>  * Rename qdev_prop_default_set_link() to
>    qdev_prop_allow_set_link_before_realize()
> 
> v2:
>  * A NULL set() callback should make the property read-only
> 
> There are two problems with QOM link properties:
> 
> 1. There are refcount leaks in many object_property_add_link() callers.
> 2. There is no way to prevent link properties from being set after a device is
>    realized.
> 
> This patch series fixes these issues by extending the
> object_property_add_link() function.
> 
> Stefan Hajnoczi (5):
>   qom: split object_property_set_link()
>   qom: don't make link NULL on object_property_set_link() failure
>   qom: make QOM link property unref optional
>   qom: add check() argument to object_property_add_link()
>   virtio-rng: avoid default_backend refcount leak
> 
>  hw/core/qdev-properties.c    |  12 ++++
>  hw/core/qdev.c               |  10 +++-
>  hw/dma/xilinx_axidma.c       |  20 +++++--
>  hw/net/xilinx_axienet.c      |  20 +++++--
>  hw/pcmcia/pxa2xx.c           |   4 +-
>  hw/s390x/s390-virtio-bus.c   |   4 +-
>  hw/s390x/virtio-ccw.c        |   4 +-
>  hw/virtio/virtio-pci.c       |   4 +-
>  hw/virtio/virtio-rng.c       |   7 ++-
>  include/hw/qdev-properties.h |  11 ++++
>  include/qom/object.h         |  29 +++++++++-
>  qom/object.c                 | 130 ++++++++++++++++++++++++++++++++-----------
>  ui/console.c                 |   5 +-
>  13 files changed, 211 insertions(+), 49 deletions(-)

Ping?