From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55659) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPvUP-0000Re-C8 for qemu-devel@nongnu.org; Tue, 18 Mar 2014 10:59:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WPvUJ-0004kG-CY for qemu-devel@nongnu.org; Tue, 18 Mar 2014 10:59:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19771) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPvUJ-0004k9-4M for qemu-devel@nongnu.org; Tue, 18 Mar 2014 10:59:31 -0400 Date: Tue, 18 Mar 2014 16:59:20 +0200 From: "Michael S. Tsirkin" Message-ID: <20140318145920.GB28344@redhat.com> References: <1395093205-46337-1-git-send-email-borntraeger@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1395093205-46337-1-git-send-email-borntraeger@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH] vl.c: Fix memory leak in qemu_register_machine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger Cc: Peter Maydell , "qemu-devel@nongnu.org" , Andreas =?iso-8859-1?Q?F=E4rber?= , Marcel Apfelbaum On Mon, Mar 17, 2014 at 10:53:25PM +0100, Christian Borntraeger wrote: > since commit 261747f176f6 (vl: Use MachineClass instead of global > QEMUMachine list) valgrind complains about the following: > > ==54082== 57 bytes in 3 blocks are definitely lost in loss record 365 of 729 > ==54082== at 0x4031AFE: malloc (vg_replace_malloc.c:292) > ==54082== by 0x4145569: g_malloc (in /usr/lib64/libglib-2.0.so.0.3400.2) > ==54082== by 0x415F9E9: g_strconcat (in /usr/lib64/libglib-2.0.so.0.3400.2) > ==54082== by 0x80157FE7: qemu_register_machine (vl.c:1597) > ==54082== by 0x80208E6B: module_call_init (module.c:105) > ==54082== by 0x80013B91: main (vl.c:3000) > > Turns out that valgrind is right. We simply forget the memory that > g_strconcat has allocated. Lets free it after the type_register. > > Signed-off-by: Christian Borntraeger > --- > vl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/vl.c b/vl.c > index b363a21..97290c9 100644 > --- a/vl.c > +++ b/vl.c > @@ -1592,6 +1592,7 @@ int qemu_register_machine(QEMUMachine *m) > }; > > type_register(&ti); > + g_free((void *) ti.name); > > return 0; > } I think it's best to avoid casting away constness. How about keeping a copy of name and freeing that? > -- > 1.8.4.2