From: Stuart Brady <sdb@zubnet.me.uk>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] target-alpha: fix subl and s8subl indentation
Date: Tue, 18 Mar 2014 21:33:04 +0000 [thread overview]
Message-ID: <20140318213304.GA32158@zubnet.me.uk> (raw)
In-Reply-To: <5324BABA.7090809@twiddle.net>
On Sat, Mar 15, 2014 at 01:40:26PM -0700, Richard Henderson wrote:
> On 03/15/2014 11:33 AM, Paolo Bonzini wrote:
> > Two missing braces, one close and one open, fabulously let the code
> > compile.
> >
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>
> Wow. That's ... amazing.
>
> Reviewed-by: Richard Henderson <rth@twiddle.net>
The *really* amazing thing about this (at least as far as I can see) is
the missing braces didn't alter the semantics of the code, except that
with the patch we no longer generate an extra TCG op with no effect...
--
Cheers,
Stuart
next prev parent reply other threads:[~2014-03-18 21:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-15 18:33 [Qemu-devel] [PATCH] target-alpha: fix subl and s8subl indentation Paolo Bonzini
2014-03-15 20:40 ` Richard Henderson
2014-03-18 21:33 ` Stuart Brady [this message]
2014-03-15 23:47 ` Peter Maydell
2014-03-16 7:59 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140318213304.GA32158@zubnet.me.uk \
--to=sdb@zubnet.me.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).