From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34499)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sdb@zubnet.me.uk>) id 1WQ1eG-0000Gs-L0
	for qemu-devel@nongnu.org; Tue, 18 Mar 2014 17:34:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sdb@zubnet.me.uk>) id 1WQ1eD-0000NN-O1
	for qemu-devel@nongnu.org; Tue, 18 Mar 2014 17:34:12 -0400
Received: from b.painless.aa.net.uk ([2001:8b0:0:30::51bb:1e34]:59495)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sdb@zubnet.me.uk>) id 1WQ1eD-0008Qa-Hn
	for qemu-devel@nongnu.org; Tue, 18 Mar 2014 17:34:09 -0400
Received: from
	3.f.1.f.6.a.0.6.9.d.c.7.8.8.5.1.9.0.3.d.f.7.a.c.0.b.8.0.1.0.0.2.ip6.arpa
	([2001:8b0:ca7f:d309:1588:7cd9:60a6:f1f3] helo=athena.zubnet.me.uk)
	by b.painless.aa.net.uk with esmtps (TLSv1:AES128-SHA:128)
	(Exim 4.72) (envelope-from <sdb@zubnet.me.uk>) id 1WQ1dB-0006aY-4Z
	for qemu-devel@nongnu.org; Tue, 18 Mar 2014 21:33:06 +0000
Received: from sdb by athena.zubnet.me.uk with local (Exim 4.82)
	(envelope-from <sdb@zubnet.me.uk>) id 1WQ1dA-0000Q0-Ex
	for qemu-devel@nongnu.org; Tue, 18 Mar 2014 21:33:04 +0000
Date: Tue, 18 Mar 2014 21:33:04 +0000
From: Stuart Brady <sdb@zubnet.me.uk>
Message-ID: <20140318213304.GA32158@zubnet.me.uk>
References: <1394908420-6981-1-git-send-email-pbonzini@redhat.com>
	<5324BABA.7090809@twiddle.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5324BABA.7090809@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] target-alpha: fix subl and s8subl
 indentation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Sat, Mar 15, 2014 at 01:40:26PM -0700, Richard Henderson wrote:
> On 03/15/2014 11:33 AM, Paolo Bonzini wrote:
> > Two missing braces, one close and one open, fabulously let the code
> > compile.
> > 
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> 
> Wow.  That's ... amazing.
> 
> Reviewed-by: Richard Henderson <rth@twiddle.net>

The *really* amazing thing about this (at least as far as I can see) is
the missing braces didn't alter the semantics of the code, except that
with the patch we no longer generate an extra TCG op with no effect...
-- 
Cheers,
Stuart