From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53053)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1WQBl8-0001q0-Cm
	for qemu-devel@nongnu.org; Wed, 19 Mar 2014 04:22:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1WQBl2-0007sC-DT
	for qemu-devel@nongnu.org; Wed, 19 Mar 2014 04:21:58 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41621)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1WQBl2-0007s8-5b
	for qemu-devel@nongnu.org; Wed, 19 Mar 2014 04:21:52 -0400
Date: Wed, 19 Mar 2014 16:21:56 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20140319082156.GC2034@T430.redhat.com>
References: <1395161452-5123-1-git-send-email-stefanha@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1395161452-5123-1-git-send-email-stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-2.0] dataplane: fix implicit IOThread
 refcount
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org

On Tue, 03/18 17:50, Stefan Hajnoczi wrote:
> When creating an IOThread implicitly (the user did not specify
> x-iothread=<id>) remember that iothread_find() does not return the
> object with an incremented refcount.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  hw/block/dataplane/virtio-blk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c
> index a5afc21..f558b45 100644
> --- a/hw/block/dataplane/virtio-blk.c
> +++ b/hw/block/dataplane/virtio-blk.c
> @@ -393,7 +393,6 @@ void virtio_blk_data_plane_create(VirtIODevice *vdev, VirtIOBlkConf *blk,
>      if (blk->iothread) {
>          s->internal_iothread = false;
>          s->iothread = blk->iothread;
> -        object_ref(OBJECT(s->iothread));
>      } else {
>          /* Create per-device IOThread if none specified */
>          Error *local_err = NULL;
> @@ -408,6 +407,7 @@ void virtio_blk_data_plane_create(VirtIODevice *vdev, VirtIOBlkConf *blk,
>          s->iothread = iothread_find(vdev->name);
>          assert(s->iothread);
>      }
> +    object_ref(OBJECT(s->iothread));
>      s->ctx = iothread_get_aio_context(s->iothread);
>  
>      /* Prevent block operations that conflict with data plane thread */

Reviewed-by: Fam Zheng <famz@redhat.com>