* [Qemu-devel] [PATCH for-2.0] dataplane: fix implicit IOThread refcount
@ 2014-03-18 16:50 Stefan Hajnoczi
2014-03-19 8:21 ` Fam Zheng
2014-03-19 8:46 ` Kevin Wolf
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2014-03-18 16:50 UTC (permalink / raw)
To: qemu-devel; +Cc: Kevin Wolf, Peter Maydell, Stefan Hajnoczi
When creating an IOThread implicitly (the user did not specify
x-iothread=<id>) remember that iothread_find() does not return the
object with an incremented refcount.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
hw/block/dataplane/virtio-blk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c
index a5afc21..f558b45 100644
--- a/hw/block/dataplane/virtio-blk.c
+++ b/hw/block/dataplane/virtio-blk.c
@@ -393,7 +393,6 @@ void virtio_blk_data_plane_create(VirtIODevice *vdev, VirtIOBlkConf *blk,
if (blk->iothread) {
s->internal_iothread = false;
s->iothread = blk->iothread;
- object_ref(OBJECT(s->iothread));
} else {
/* Create per-device IOThread if none specified */
Error *local_err = NULL;
@@ -408,6 +407,7 @@ void virtio_blk_data_plane_create(VirtIODevice *vdev, VirtIOBlkConf *blk,
s->iothread = iothread_find(vdev->name);
assert(s->iothread);
}
+ object_ref(OBJECT(s->iothread));
s->ctx = iothread_get_aio_context(s->iothread);
/* Prevent block operations that conflict with data plane thread */
--
1.8.5.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH for-2.0] dataplane: fix implicit IOThread refcount
2014-03-18 16:50 [Qemu-devel] [PATCH for-2.0] dataplane: fix implicit IOThread refcount Stefan Hajnoczi
@ 2014-03-19 8:21 ` Fam Zheng
2014-03-19 8:46 ` Kevin Wolf
1 sibling, 0 replies; 3+ messages in thread
From: Fam Zheng @ 2014-03-19 8:21 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: Kevin Wolf, Peter Maydell, qemu-devel
On Tue, 03/18 17:50, Stefan Hajnoczi wrote:
> When creating an IOThread implicitly (the user did not specify
> x-iothread=<id>) remember that iothread_find() does not return the
> object with an incremented refcount.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> hw/block/dataplane/virtio-blk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c
> index a5afc21..f558b45 100644
> --- a/hw/block/dataplane/virtio-blk.c
> +++ b/hw/block/dataplane/virtio-blk.c
> @@ -393,7 +393,6 @@ void virtio_blk_data_plane_create(VirtIODevice *vdev, VirtIOBlkConf *blk,
> if (blk->iothread) {
> s->internal_iothread = false;
> s->iothread = blk->iothread;
> - object_ref(OBJECT(s->iothread));
> } else {
> /* Create per-device IOThread if none specified */
> Error *local_err = NULL;
> @@ -408,6 +407,7 @@ void virtio_blk_data_plane_create(VirtIODevice *vdev, VirtIOBlkConf *blk,
> s->iothread = iothread_find(vdev->name);
> assert(s->iothread);
> }
> + object_ref(OBJECT(s->iothread));
> s->ctx = iothread_get_aio_context(s->iothread);
>
> /* Prevent block operations that conflict with data plane thread */
Reviewed-by: Fam Zheng <famz@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH for-2.0] dataplane: fix implicit IOThread refcount
2014-03-18 16:50 [Qemu-devel] [PATCH for-2.0] dataplane: fix implicit IOThread refcount Stefan Hajnoczi
2014-03-19 8:21 ` Fam Zheng
@ 2014-03-19 8:46 ` Kevin Wolf
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Wolf @ 2014-03-19 8:46 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: Peter Maydell, qemu-devel
Am 18.03.2014 um 17:50 hat Stefan Hajnoczi geschrieben:
> When creating an IOThread implicitly (the user did not specify
> x-iothread=<id>) remember that iothread_find() does not return the
> object with an incremented refcount.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Thanks, applied to the block branch for qemu 2.0.
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-19 8:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-18 16:50 [Qemu-devel] [PATCH for-2.0] dataplane: fix implicit IOThread refcount Stefan Hajnoczi
2014-03-19 8:21 ` Fam Zheng
2014-03-19 8:46 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).