From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48545) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQGqL-0000Iu-Nn for qemu-devel@nongnu.org; Wed, 19 Mar 2014 09:47:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQGqG-0007zF-N9 for qemu-devel@nongnu.org; Wed, 19 Mar 2014 09:47:41 -0400 Received: from lputeaux-656-01-25-125.w80-12.abo.wanadoo.fr ([80.12.84.125]:56323 helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQGqG-0007zA-Hg for qemu-devel@nongnu.org; Wed, 19 Mar 2014 09:47:36 -0400 Date: Wed, 19 Mar 2014 14:47:36 +0100 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20140319134736.GD3019@irqsave.net> References: <95e71dbde56dc7cf82dab8faa315ea516169838b.1395105370.git.jcody@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <95e71dbde56dc7cf82dab8faa315ea516169838b.1395105370.git.jcody@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 4/4] block: qemu-iotests: make test 019 and 086 work with spaced pathnames List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com The Monday 17 Mar 2014 =E0 21:24:40 (-0400), Jeff Cody wrote : > Both tests 019 and 086 need proper quotations to work with pathnames > that contain spaces. >=20 > Signed-off-by: Jeff Cody > --- > tests/qemu-iotests/019 | 2 +- > tests/qemu-iotests/086 | 8 ++++---- > 2 files changed, 5 insertions(+), 5 deletions(-) >=20 > diff --git a/tests/qemu-iotests/019 b/tests/qemu-iotests/019 > index e67445c..f5ecbf5 100755 > --- a/tests/qemu-iotests/019 > +++ b/tests/qemu-iotests/019 > @@ -96,7 +96,7 @@ mv "$TEST_IMG" "$TEST_IMG.orig" > for backing_option in "-B " "-o backing_file=3D"; do > =20 > echo > - echo Testing conversion with $backing_option$TEST_IMG.base | _filt= er_testdir | _filter_imgfmt > + echo Testing conversion with $backing_option"$TEST_IMG.base" | _fi= lter_testdir | _filter_imgfmt > echo > $QEMU_IMG convert -O $IMGFMT $backing_option"$TEST_IMG.base" "$TES= T_IMG.orig" "$TEST_IMG" > =20 > diff --git a/tests/qemu-iotests/086 b/tests/qemu-iotests/086 > index 48fe85b..d9a80cf 100755 > --- a/tests/qemu-iotests/086 > +++ b/tests/qemu-iotests/086 > @@ -51,10 +51,10 @@ function run_qemu_img() > size=3D128M > =20 > _make_test_img $size > -$QEMU_IO -c 'write 0 1M' $TEST_IMG | _filter_qemu_io > -$QEMU_IO -c 'write 2M 1M' $TEST_IMG | _filter_qemu_io > -$QEMU_IO -c 'write 4M 1M' $TEST_IMG | _filter_qemu_io > -$QEMU_IO -c 'write 32M 1M' $TEST_IMG | _filter_qemu_io > +$QEMU_IO -c 'write 0 1M' "$TEST_IMG" | _filter_qemu_io > +$QEMU_IO -c 'write 2M 1M' "$TEST_IMG" | _filter_qemu_io > +$QEMU_IO -c 'write 4M 1M' "$TEST_IMG" | _filter_qemu_io > +$QEMU_IO -c 'write 32M 1M' "$TEST_IMG" | _filter_qemu_io > =20 > $QEMU_IMG convert -p -O $IMGFMT -f $IMGFMT "$TEST_IMG" "$TEST_IMG".bas= e 2>&1 |\ > _filter_testdir | sed -e 's/\r/\n/g' > --=20 > 1.8.3.1 >=20 >=20 Reviewed-by: Benoit Canet