qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	qemu-devel@nongnu.org, Guillaume Subiron <maethor@subiron.org>
Subject: Re: [Qemu-devel] [PATCHv3 00/16] slirp: Adding IPv6 support to Qemu -net user mode
Date: Thu, 20 Mar 2014 08:58:11 +0100	[thread overview]
Message-ID: <20140320075811.GA28673@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <53200C56.6040300@siemens.com>

On Wed, Mar 12, 2014 at 08:27:18AM +0100, Jan Kiszka wrote:
> On 2014-02-11 14:08, Samuel Thibault wrote:
> > Hello,
> > 
> > This is a respin of IPv6 in Qemu -net user mode.
> > 
> > These patches add ICMPv6, NDP, and make UDP and TCP compatible with
> > IPv6. We have made some refactoring to make current code compatible with
> > IPv6.
> > 
> > Some patches, like 2 and 13, can be reviewed using
> > "interdiff -w /dev/null patchfile"
> > to get rid of the indentation.
> 
> The alternative is to split reindention from refactoring patches.
> 
> > 
> > Difference with version 2 is:
> > - The default IP range has been made fec0::/64 instead of fc00::/64
> > 
> 
> This is very valuable work. Unfortunately, I'm lacking time to review or
> even test this ATM. If someone else could, that would be great.

I also feel a little sad to see this major feature languish but don't
have much time at the moment.

My suggestion is to split all the preparation and cleanups into a
smaller patch series that can be applied easily.

It will make the real IPv6 series smaller and hopefully more amenable to
review.

Stefan

  reply	other threads:[~2014-03-20  7:58 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1374334058-27898-1-git-send-email-maethor@subiron.org>
2013-10-20 14:54 ` [Qemu-devel] [PATCH 00/16] slirp: Adding IPv6 support to Qemu -net user mode Samuel Thibault
2013-10-20 14:56   ` [Qemu-devel] [PATCH 01/16] slirp: goto bad in udp_input if sosendto fails Samuel Thibault
2013-10-20 14:56     ` [Qemu-devel] [PATCH 02/16] slirp: Generalizing and neutralizing code before adding IPv6 stuff Samuel Thibault
2013-10-20 14:56     ` [Qemu-devel] [PATCH 03/16] qemu/timer.h : Adding function to second scale Samuel Thibault
2013-10-20 14:56     ` [Qemu-devel] [PATCH 04/16] slirp: Adding IPv6, ICMPv6 Echo and NDP autoconfiguration Samuel Thibault
2013-10-23  7:51       ` Paolo Bonzini
2013-10-23 22:49         ` Samuel Thibault
2013-10-20 14:56     ` [Qemu-devel] [PATCH 05/16] slirp: Adding ICMPv6 error sending Samuel Thibault
2013-10-20 14:56     ` [Qemu-devel] [PATCH 06/16] slirp: Make Socket structure IPv6 compatible Samuel Thibault
2013-10-20 14:56     ` [Qemu-devel] [PATCH 07/16] slirp: Factorizing address translation Samuel Thibault
2013-10-20 14:56     ` [Qemu-devel] [PATCH 08/16] slirp: Factorizing and cleaning solookup() Samuel Thibault
2013-10-20 14:56     ` [Qemu-devel] [PATCH 09/16] slirp: Make udp_attach IPv6 compatible Samuel Thibault
2013-10-20 14:56     ` [Qemu-devel] [PATCH 10/16] slirp: Adding IPv6 UDP support Samuel Thibault
2013-10-20 14:56     ` [Qemu-devel] [PATCH 11/16] slirp: Adding family argument to tcp_fconnect() Samuel Thibault
2013-10-20 14:56     ` [Qemu-devel] [PATCH 12/16] slirp: Factorizing tcpiphdr structure with an union Samuel Thibault
2013-10-20 14:56     ` [Qemu-devel] [PATCH 13/16] slirp: Generalizing and neutralizing various TCP functions before adding IPv6 stuff Samuel Thibault
2013-10-20 14:56     ` [Qemu-devel] [PATCH 14/16] slirp: Handle IPv6 in TCP functions Samuel Thibault
2013-10-20 14:56     ` [Qemu-devel] [PATCH 15/16] slirp: Adding IPv6 address for DNS relay Samuel Thibault
2013-10-20 14:56     ` [Qemu-devel] [PATCH 16/16] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses Samuel Thibault
2013-10-21 21:04       ` Eric Blake
2013-10-22 10:22         ` Samuel Thibault
2013-10-22 10:27           ` Eric Blake
2013-10-22 10:31             ` Samuel Thibault
2013-10-22 10:33               ` Eric Blake
2013-10-22 10:45                 ` Samuel Thibault
2013-10-22 10:48                   ` Eric Blake
2013-10-22 10:52                     ` Eric Blake
2013-10-22 14:11                       ` Samuel Thibault
2013-10-22 14:48                         ` Eric Blake
2013-10-22 19:12                           ` Samuel Thibault
2013-10-22 20:25                             ` Eric Blake
2013-11-17 15:04   ` [Qemu-devel] [PATCHv2 00/16] slirp: Adding IPv6 support to Qemu -net user mode Samuel Thibault
2013-11-17 15:04     ` [Qemu-devel] [PATCH 01/16] slirp: goto bad in udp_input if sosendto fails Samuel Thibault
2013-11-17 15:04     ` [Qemu-devel] [PATCH 02/16] slirp: Generalizing and neutralizing code before adding IPv6 stuff Samuel Thibault
2013-11-17 15:04     ` [Qemu-devel] [PATCH 03/16] qemu/timer.h : Adding function to second scale Samuel Thibault
2013-11-17 15:04     ` [Qemu-devel] [PATCH 04/16] slirp: Adding IPv6, ICMPv6 Echo and NDP autoconfiguration Samuel Thibault
2013-11-17 15:04     ` [Qemu-devel] [PATCH 05/16] slirp: Adding ICMPv6 error sending Samuel Thibault
2013-11-17 15:04     ` [Qemu-devel] [PATCH 06/16] slirp: Make Socket structure IPv6 compatible Samuel Thibault
2013-11-17 15:04     ` [Qemu-devel] [PATCH 07/16] slirp: Factorizing address translation Samuel Thibault
2013-11-17 15:04     ` [Qemu-devel] [PATCH 08/16] slirp: Factorizing and cleaning solookup() Samuel Thibault
2013-11-17 15:04     ` [Qemu-devel] [PATCH 09/16] slirp: Make udp_attach IPv6 compatible Samuel Thibault
2013-11-17 15:04     ` [Qemu-devel] [PATCH 10/16] slirp: Adding IPv6 UDP support Samuel Thibault
2013-11-17 15:04     ` [Qemu-devel] [PATCH 11/16] slirp: Adding family argument to tcp_fconnect() Samuel Thibault
2013-11-17 15:04     ` [Qemu-devel] [PATCH 12/16] slirp: Factorizing tcpiphdr structure with an union Samuel Thibault
2013-11-17 15:04     ` [Qemu-devel] [PATCH 13/16] slirp: Generalizing and neutralizing various TCP functions before adding IPv6 stuff Samuel Thibault
2013-11-17 15:04     ` [Qemu-devel] [PATCH 14/16] slirp: Handle IPv6 in TCP functions Samuel Thibault
2013-11-17 15:04     ` [Qemu-devel] [PATCH 15/16] slirp: Adding IPv6 address for DNS relay Samuel Thibault
2013-11-17 15:04     ` [Qemu-devel] [PATCH 16/16] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses Samuel Thibault
2014-02-11 13:08     ` [Qemu-devel] [PATCHv3 00/16] slirp: Adding IPv6 support to Qemu -net user mode Samuel Thibault
2014-02-11 13:08       ` [Qemu-devel] [PATCH 01/16] slirp: goto bad in udp_input if sosendto fails Samuel Thibault
2014-06-11  8:55         ` [Qemu-devel] [PATCH] " Samuel Thibault
2014-06-12  5:47           ` Jan Kiszka
2014-06-14 19:45             ` Samuel Thibault
2014-07-11 10:18         ` Samuel Thibault
2014-02-11 13:08       ` [Qemu-devel] [PATCH 02/16] slirp: Generalizing and neutralizing code before adding IPv6 stuff Samuel Thibault
2014-02-11 13:08       ` [Qemu-devel] [PATCH 03/16] qemu/timer.h : Adding function to second scale Samuel Thibault
2014-02-11 13:08       ` [Qemu-devel] [PATCH 04/16] slirp: Adding IPv6, ICMPv6 Echo and NDP autoconfiguration Samuel Thibault
2014-02-11 13:08       ` [Qemu-devel] [PATCH 05/16] slirp: Adding ICMPv6 error sending Samuel Thibault
2014-02-11 13:08       ` [Qemu-devel] [PATCH 06/16] slirp: Make Socket structure IPv6 compatible Samuel Thibault
2014-02-11 13:08       ` [Qemu-devel] [PATCH 07/16] slirp: Factorizing address translation Samuel Thibault
2014-02-11 13:08       ` [Qemu-devel] [PATCH 08/16] slirp: Factorizing and cleaning solookup() Samuel Thibault
2014-02-11 13:08       ` [Qemu-devel] [PATCH 09/16] slirp: Make udp_attach IPv6 compatible Samuel Thibault
2014-02-11 13:08       ` [Qemu-devel] [PATCH 10/16] slirp: Adding IPv6 UDP support Samuel Thibault
2014-02-11 13:08       ` [Qemu-devel] [PATCH 11/16] slirp: Adding family argument to tcp_fconnect() Samuel Thibault
2014-02-11 13:08       ` [Qemu-devel] [PATCH 12/16] slirp: Factorizing tcpiphdr structure with an union Samuel Thibault
2014-02-11 13:08       ` [Qemu-devel] [PATCH 13/16] slirp: Generalizing and neutralizing various TCP functions before adding IPv6 stuff Samuel Thibault
2014-02-11 13:08       ` [Qemu-devel] [PATCH 14/16] slirp: Handle IPv6 in TCP functions Samuel Thibault
2014-02-11 13:08       ` [Qemu-devel] [PATCH 15/16] slirp: Adding IPv6 address for DNS relay Samuel Thibault
2014-02-11 13:08       ` [Qemu-devel] [PATCH 16/16] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses Samuel Thibault
2014-03-27 21:42         ` Eric Blake
2014-02-11 13:50       ` [Qemu-devel] [PATCHv3 00/16] slirp: Adding IPv6 support to Qemu -net user mode Eric Blake
2014-02-11 14:35         ` Samuel Thibault
2014-02-11 14:42           ` Max Filippov
2014-02-11 14:48             ` Max Filippov
2014-03-12  7:27       ` Jan Kiszka
2014-03-20  7:58         ` Stefan Hajnoczi [this message]
2014-03-20  9:03           ` Samuel Thibault
2014-04-04 18:20             ` Samuel Thibault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140320075811.GA28673@stefanha-thinkpad.redhat.com \
    --to=stefanha@gmail.com \
    --cc=jan.kiszka@siemens.com \
    --cc=maethor@subiron.org \
    --cc=qemu-devel@nongnu.org \
    --cc=samuel.thibault@ens-lyon.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).