From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51109)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WQXrt-0008JS-4Y
	for qemu-devel@nongnu.org; Thu, 20 Mar 2014 03:58:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WQXrk-00044Y-Mr
	for qemu-devel@nongnu.org; Thu, 20 Mar 2014 03:58:25 -0400
Received: from mail-we0-x229.google.com ([2a00:1450:400c:c03::229]:40057)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WQXrk-00044K-Fj
	for qemu-devel@nongnu.org; Thu, 20 Mar 2014 03:58:16 -0400
Received: by mail-we0-f169.google.com with SMTP id w62so297442wes.28
	for <qemu-devel@nongnu.org>; Thu, 20 Mar 2014 00:58:15 -0700 (PDT)
Date: Thu, 20 Mar 2014 08:58:11 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20140320075811.GA28673@stefanha-thinkpad.redhat.com>
References: <1384700688-30377-1-git-send-email-samuel.thibault@ens-lyon.org>
	<1392124097-10618-1-git-send-email-samuel.thibault@ens-lyon.org>
	<53200C56.6040300@siemens.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <53200C56.6040300@siemens.com>
Subject: Re: [Qemu-devel] [PATCHv3 00/16] slirp: Adding IPv6 support to Qemu
 -net user mode
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>, qemu-devel@nongnu.org, Guillaume Subiron <maethor@subiron.org>

On Wed, Mar 12, 2014 at 08:27:18AM +0100, Jan Kiszka wrote:
> On 2014-02-11 14:08, Samuel Thibault wrote:
> > Hello,
> > 
> > This is a respin of IPv6 in Qemu -net user mode.
> > 
> > These patches add ICMPv6, NDP, and make UDP and TCP compatible with
> > IPv6. We have made some refactoring to make current code compatible with
> > IPv6.
> > 
> > Some patches, like 2 and 13, can be reviewed using
> > "interdiff -w /dev/null patchfile"
> > to get rid of the indentation.
> 
> The alternative is to split reindention from refactoring patches.
> 
> > 
> > Difference with version 2 is:
> > - The default IP range has been made fec0::/64 instead of fc00::/64
> > 
> 
> This is very valuable work. Unfortunately, I'm lacking time to review or
> even test this ATM. If someone else could, that would be great.

I also feel a little sad to see this major feature languish but don't
have much time at the moment.

My suggestion is to split all the preparation and cleanups into a
smaller patch series that can be applied easily.

It will make the real IPv6 series smaller and hopefully more amenable to
review.

Stefan