From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48469)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1WQcWH-000443-Gh
	for qemu-devel@nongnu.org; Thu, 20 Mar 2014 08:56:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1WQcWC-0007N1-GD
	for qemu-devel@nongnu.org; Thu, 20 Mar 2014 08:56:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:54100)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1WQcWC-0007Ms-8G
	for qemu-devel@nongnu.org; Thu, 20 Mar 2014 08:56:20 -0400
Date: Thu, 20 Mar 2014 08:56:12 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20140320085612.657b7001@redhat.com>
In-Reply-To: <532A12F3.5000708@suse.de>
References: <20140319170353.4428b501@redhat.com>
	<532A12F3.5000708@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 for-2.0] target-i386:
 x86_cpu_get_phys_page_debug(): support 1GB page translation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?UTF-8?B?RsOkcmJlcg==?= <afaerber@suse.de>
Cc: peter.maydell@linaro.org, pbonzini@redhat.com, qemu-devel <qemu-devel@nongnu.org>, jan.kiszka@siemens.com

On Wed, 19 Mar 2014 22:58:11 +0100
Andreas F=C3=A4rber <afaerber@suse.de> wrote:

> Am 19.03.2014 22:03, schrieb Luiz Capitulino:
> > Linux guests, when using more than 4GB of RAM, may end up using 1GB pag=
es
> > to store (kernel) data. When this happens, we're unable to debug a runn=
ing
> > Linux kernel with GDB:
> >=20
> > (gdb) p node_data[0]->node_id
> > Cannot access memory at address 0xffff88013fffd3a0
> > (gdb)
> >=20
> > GDB returns this error because x86_cpu_get_phys_page_debug() doesn't su=
pport
> > translating 1GB pages in IA-32e paging mode and returns an error to GDB.
> >=20
> > This commit adds support for 1GB page translation for IA32e paging.
> >=20
> > Signed-off-by: Luiz capitulino <lcapitulino@redhat.com>
>=20
> Capitulino? :)

Can you or Peter fix it when merging?

> > ---
> >=20
> > - I'm proposing this patch for 2.0 because GDB debugging of large Linux
> >   guests is kind of broken
>=20
> Agree that it would be nice to fix, but having mainly touched the
> function interface, I am dependent on reviewers here. =3D> rc2 or .1

I think Paolo and/or Jan will review it.

>=20
> Regards,
> Andreas
>=20
> >=20
> > - Changelog v2:
> >   - Move PS bit handling to if (env->hflags & HF_LMA_MASK) block
> >   - Update changelog
> >=20
> >  target-i386/helper.c | 9 +++++++++
> >  1 file changed, 9 insertions(+)
>=20