From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48893)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WQcY3-0006p9-Fe
	for qemu-devel@nongnu.org; Thu, 20 Mar 2014 08:58:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WQcXv-0007xC-Tn
	for qemu-devel@nongnu.org; Thu, 20 Mar 2014 08:58:15 -0400
Received: from mx1.redhat.com ([209.132.183.28]:30592)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WQcXv-0007ws-Lz
	for qemu-devel@nongnu.org; Thu, 20 Mar 2014 08:58:07 -0400
Date: Thu, 20 Mar 2014 11:13:18 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20140320101318.GA1936@stefanha-thinkpad.redhat.com>
References: <1394719868-24312-1-git-send-email-stefanha@redhat.com>
	<1394719868-24312-14-git-send-email-stefanha@redhat.com>
	<53271A5B.9080906@de.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <53271A5B.9080906@de.ibm.com>
Subject: Re: [Qemu-devel] [PULL v2 for-2.0 13/24] dataplane: replace
 internal thread with IOThread
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Dominik Dingel <dingel@linux.vnet.ibm.com>, Jens Freimann <jfrei@linux.vnet.ibm.com>, Anthony Liguori <aliguori@amazon.com>, Cornelia Huck <cornelia.huck@de.ibm.com>

On Mon, Mar 17, 2014 at 04:52:59PM +0100, Christian Borntraeger wrote:
> This causes the following bug during managedsave of s390 with a guest that has multiple disks with dataplane.
> 
> (gdb) bt
> #0  object_deinit (type=0x0, obj=0x807e8750) at /home/cborntra/REPOS/qemu/qom/object.c:410
> #1  object_finalize (data=0x807e8750) at /home/cborntra/REPOS/qemu/qom/object.c:424
> #2  object_unref (obj=0x807e8750) at /home/cborntra/REPOS/qemu/qom/object.c:726
> #3  0x000000008011da60 in object_property_del (obj=0x807e8d80, name=0x807e8d60 "virtio-blk", errp=<optimized out>) at /home/cborntra/REPOS/qemu/qom/object.c:783
> #4  0x000000008011dc0e in object_property_del_child (errp=0x0, child=0x807e8750, obj=0x807e8d80) at /home/cborntra/REPOS/qemu/qom/object.c:386
> #5  object_unparent (obj=0x807e8750) at /home/cborntra/REPOS/qemu/qom/object.c:403
> #6  0x0000000080183898 in virtio_blk_data_plane_destroy (s=0x8088a750) at /home/cborntra/REPOS/qemu/hw/block/dataplane/virtio-blk.c:430

Are you able to reproduce this reliably?

198fd05c357afff22f0b0e02639937519ed49b1f should have fixed it.

Stefan